-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter/debug] change behavior of "normal" verbosity to be different from "basic" #7806
Comments
I also find logging exporter output a bit too verbose. It would be awesome if I could provide a "template" for output - so that I can choose which metadata I want to see. Another name for this mode could be |
I agree this might be very useful. A bit more complex (need to define the "templating language", even if very basic), but very useful. |
Also, what happened to log level ? Why cannot you filter out errors only? |
@herrbpl, the |
Related issue: I believe #8844 should be done first. |
…8846) This change has currently no effect, as `basic` and `normal` verbosity share the same behavior. This might change in the future though, with the `normal` verbosity being more verbose than it currently is (see #7806). This is why we are changing the default to `basic`, which is expected to stay at the current level of verbosity (one line per batch). **Link to tracking Issue:** - #8844
….90.0 (#30) [![Mend Renovate logo banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [go.opentelemetry.io/collector/receiver](https://github.com/open-telemetry/opentelemetry-collector) | require | minor | `v0.89.0` -> `v0.90.0` | --- ### Release Notes <details> <summary>open-telemetry/opentelemetry-collector (go.opentelemetry.io/collector/receiver)</summary> ### [`v0.90.0`](https://github.com/open-telemetry/opentelemetry-collector/blob/HEAD/CHANGELOG.md#v100v0900) [Compare Source](https://github.com/open-telemetry/opentelemetry-collector/compare/v0.89.0...v0.90.0) ##### 🛑 Breaking changes 🛑 - `service`: To remain backwards compatible w/ the metrics generated today, otel generated metrics will be generated without the `_total` suffix ([#​7454](https://github.com/open-telemetry/opentelemetry-collector/issues/7454)) - `service`: use WithNamespace instead of WrapRegistererWithPrefix ([#​8988](https://github.com/open-telemetry/opentelemetry-collector/issues/8988)) Using this functionality in the otel prom exporter fixes a bug where the target_info was prefixed as otelcol_target_info previously. ##### 💡 Enhancements 💡 - `exporter/debug`: Change default `verbosity` from `normal` to `basic` ([#​8844](https://github.com/open-telemetry/opentelemetry-collector/issues/8844)) This change has currently no effect, as `basic` and `normal` verbosity share the same behavior. This might change in the future though, with the `normal` verbosity being more verbose than it currently is (see [https://github.com/open-telemetry/opentelemetry-collector/issues/7806](https://github.com/open-telemetry/opentelemetry-collector/issues/7806)). This is why we are changing the default to `basic`, which is expected to stay at the current level of verbosity (one line per batch). - `exporterhelper`: Fix shutdown logic in persistent queue to not require consumers to be closed first ([#​8899](https://github.com/open-telemetry/opentelemetry-collector/issues/8899)) - `confighttp`: Support proxy configuration field in all exporters that support confighttp ([#​5761](https://github.com/open-telemetry/opentelemetry-collector/issues/5761)) ##### 🧰 Bug fixes 🧰 - `exporterhelper`: Fix invalid write index updates in the persistent queue ([#​8115](https://github.com/open-telemetry/opentelemetry-collector/issues/8115)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ymotongpoo/opentelemetry-collector-extra). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
….90.0 (#29) [![Mend Renovate logo banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [go.opentelemetry.io/collector/exporter](https://github.com/open-telemetry/opentelemetry-collector) | require | minor | `v0.89.0` -> `v0.90.0` | --- ### Release Notes <details> <summary>open-telemetry/opentelemetry-collector (go.opentelemetry.io/collector/exporter)</summary> ### [`v0.90.0`](https://github.com/open-telemetry/opentelemetry-collector/blob/HEAD/CHANGELOG.md#v100v0900) [Compare Source](https://github.com/open-telemetry/opentelemetry-collector/compare/v0.89.0...v0.90.0) ##### 🛑 Breaking changes 🛑 - `service`: To remain backwards compatible w/ the metrics generated today, otel generated metrics will be generated without the `_total` suffix ([#​7454](https://github.com/open-telemetry/opentelemetry-collector/issues/7454)) - `service`: use WithNamespace instead of WrapRegistererWithPrefix ([#​8988](https://github.com/open-telemetry/opentelemetry-collector/issues/8988)) Using this functionality in the otel prom exporter fixes a bug where the target_info was prefixed as otelcol_target_info previously. ##### 💡 Enhancements 💡 - `exporter/debug`: Change default `verbosity` from `normal` to `basic` ([#​8844](https://github.com/open-telemetry/opentelemetry-collector/issues/8844)) This change has currently no effect, as `basic` and `normal` verbosity share the same behavior. This might change in the future though, with the `normal` verbosity being more verbose than it currently is (see [https://github.com/open-telemetry/opentelemetry-collector/issues/7806](https://github.com/open-telemetry/opentelemetry-collector/issues/7806)). This is why we are changing the default to `basic`, which is expected to stay at the current level of verbosity (one line per batch). - `exporterhelper`: Fix shutdown logic in persistent queue to not require consumers to be closed first ([#​8899](https://github.com/open-telemetry/opentelemetry-collector/issues/8899)) - `confighttp`: Support proxy configuration field in all exporters that support confighttp ([#​5761](https://github.com/open-telemetry/opentelemetry-collector/issues/5761)) ##### 🧰 Bug fixes 🧰 - `exporterhelper`: Fix invalid write index updates in the persistent queue ([#​8115](https://github.com/open-telemetry/opentelemetry-collector/issues/8115)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ymotongpoo/opentelemetry-collector-extra). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
….90.0 (#28) [![Mend Renovate logo banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [go.opentelemetry.io/collector/consumer](https://github.com/open-telemetry/opentelemetry-collector) | require | minor | `v0.89.0` -> `v0.90.0` | --- ### Release Notes <details> <summary>open-telemetry/opentelemetry-collector (go.opentelemetry.io/collector/consumer)</summary> ### [`v0.90.0`](https://github.com/open-telemetry/opentelemetry-collector/blob/HEAD/CHANGELOG.md#v100v0900) [Compare Source](https://github.com/open-telemetry/opentelemetry-collector/compare/v0.89.0...v0.90.0) ##### 🛑 Breaking changes 🛑 - `service`: To remain backwards compatible w/ the metrics generated today, otel generated metrics will be generated without the `_total` suffix ([#​7454](https://github.com/open-telemetry/opentelemetry-collector/issues/7454)) - `service`: use WithNamespace instead of WrapRegistererWithPrefix ([#​8988](https://github.com/open-telemetry/opentelemetry-collector/issues/8988)) Using this functionality in the otel prom exporter fixes a bug where the target_info was prefixed as otelcol_target_info previously. ##### 💡 Enhancements 💡 - `exporter/debug`: Change default `verbosity` from `normal` to `basic` ([#​8844](https://github.com/open-telemetry/opentelemetry-collector/issues/8844)) This change has currently no effect, as `basic` and `normal` verbosity share the same behavior. This might change in the future though, with the `normal` verbosity being more verbose than it currently is (see [https://github.com/open-telemetry/opentelemetry-collector/issues/7806](https://github.com/open-telemetry/opentelemetry-collector/issues/7806)). This is why we are changing the default to `basic`, which is expected to stay at the current level of verbosity (one line per batch). - `exporterhelper`: Fix shutdown logic in persistent queue to not require consumers to be closed first ([#​8899](https://github.com/open-telemetry/opentelemetry-collector/issues/8899)) - `confighttp`: Support proxy configuration field in all exporters that support confighttp ([#​5761](https://github.com/open-telemetry/opentelemetry-collector/issues/5761)) ##### 🧰 Bug fixes 🧰 - `exporterhelper`: Fix invalid write index updates in the persistent queue ([#​8115](https://github.com/open-telemetry/opentelemetry-collector/issues/8115)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ymotongpoo/opentelemetry-collector-extra). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
….90.0 (#30) [![Mend Renovate logo banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [go.opentelemetry.io/collector/receiver](https://github.com/open-telemetry/opentelemetry-collector) | require | minor | `v0.89.0` -> `v0.90.0` | --- ### Release Notes <details> <summary>open-telemetry/opentelemetry-collector (go.opentelemetry.io/collector/receiver)</summary> ### [`v0.90.0`](https://github.com/open-telemetry/opentelemetry-collector/blob/HEAD/CHANGELOG.md#v100v0900) [Compare Source](https://github.com/open-telemetry/opentelemetry-collector/compare/v0.89.0...v0.90.0) ##### 🛑 Breaking changes 🛑 - `service`: To remain backwards compatible w/ the metrics generated today, otel generated metrics will be generated without the `_total` suffix ([#​7454](https://github.com/open-telemetry/opentelemetry-collector/issues/7454)) - `service`: use WithNamespace instead of WrapRegistererWithPrefix ([#​8988](https://github.com/open-telemetry/opentelemetry-collector/issues/8988)) Using this functionality in the otel prom exporter fixes a bug where the target_info was prefixed as otelcol_target_info previously. ##### 💡 Enhancements 💡 - `exporter/debug`: Change default `verbosity` from `normal` to `basic` ([#​8844](https://github.com/open-telemetry/opentelemetry-collector/issues/8844)) This change has currently no effect, as `basic` and `normal` verbosity share the same behavior. This might change in the future though, with the `normal` verbosity being more verbose than it currently is (see [https://github.com/open-telemetry/opentelemetry-collector/issues/7806](https://github.com/open-telemetry/opentelemetry-collector/issues/7806)). This is why we are changing the default to `basic`, which is expected to stay at the current level of verbosity (one line per batch). - `exporterhelper`: Fix shutdown logic in persistent queue to not require consumers to be closed first ([#​8899](https://github.com/open-telemetry/opentelemetry-collector/issues/8899)) - `confighttp`: Support proxy configuration field in all exporters that support confighttp ([#​5761](https://github.com/open-telemetry/opentelemetry-collector/issues/5761)) ##### 🧰 Bug fixes 🧰 - `exporterhelper`: Fix invalid write index updates in the persistent queue ([#​8115](https://github.com/open-telemetry/opentelemetry-collector/issues/8115)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ymotongpoo/opentelemetry-collector-extra). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
….90.0 (#29) [![Mend Renovate logo banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [go.opentelemetry.io/collector/exporter](https://github.com/open-telemetry/opentelemetry-collector) | require | minor | `v0.89.0` -> `v0.90.0` | --- ### Release Notes <details> <summary>open-telemetry/opentelemetry-collector (go.opentelemetry.io/collector/exporter)</summary> ### [`v0.90.0`](https://github.com/open-telemetry/opentelemetry-collector/blob/HEAD/CHANGELOG.md#v100v0900) [Compare Source](https://github.com/open-telemetry/opentelemetry-collector/compare/v0.89.0...v0.90.0) ##### 🛑 Breaking changes 🛑 - `service`: To remain backwards compatible w/ the metrics generated today, otel generated metrics will be generated without the `_total` suffix ([#​7454](https://github.com/open-telemetry/opentelemetry-collector/issues/7454)) - `service`: use WithNamespace instead of WrapRegistererWithPrefix ([#​8988](https://github.com/open-telemetry/opentelemetry-collector/issues/8988)) Using this functionality in the otel prom exporter fixes a bug where the target_info was prefixed as otelcol_target_info previously. ##### 💡 Enhancements 💡 - `exporter/debug`: Change default `verbosity` from `normal` to `basic` ([#​8844](https://github.com/open-telemetry/opentelemetry-collector/issues/8844)) This change has currently no effect, as `basic` and `normal` verbosity share the same behavior. This might change in the future though, with the `normal` verbosity being more verbose than it currently is (see [https://github.com/open-telemetry/opentelemetry-collector/issues/7806](https://github.com/open-telemetry/opentelemetry-collector/issues/7806)). This is why we are changing the default to `basic`, which is expected to stay at the current level of verbosity (one line per batch). - `exporterhelper`: Fix shutdown logic in persistent queue to not require consumers to be closed first ([#​8899](https://github.com/open-telemetry/opentelemetry-collector/issues/8899)) - `confighttp`: Support proxy configuration field in all exporters that support confighttp ([#​5761](https://github.com/open-telemetry/opentelemetry-collector/issues/5761)) ##### 🧰 Bug fixes 🧰 - `exporterhelper`: Fix invalid write index updates in the persistent queue ([#​8115](https://github.com/open-telemetry/opentelemetry-collector/issues/8115)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ymotongpoo/opentelemetry-collector-extra). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
….90.0 (#28) [![Mend Renovate logo banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [go.opentelemetry.io/collector/consumer](https://github.com/open-telemetry/opentelemetry-collector) | require | minor | `v0.89.0` -> `v0.90.0` | --- ### Release Notes <details> <summary>open-telemetry/opentelemetry-collector (go.opentelemetry.io/collector/consumer)</summary> ### [`v0.90.0`](https://github.com/open-telemetry/opentelemetry-collector/blob/HEAD/CHANGELOG.md#v100v0900) [Compare Source](https://github.com/open-telemetry/opentelemetry-collector/compare/v0.89.0...v0.90.0) ##### 🛑 Breaking changes 🛑 - `service`: To remain backwards compatible w/ the metrics generated today, otel generated metrics will be generated without the `_total` suffix ([#​7454](https://github.com/open-telemetry/opentelemetry-collector/issues/7454)) - `service`: use WithNamespace instead of WrapRegistererWithPrefix ([#​8988](https://github.com/open-telemetry/opentelemetry-collector/issues/8988)) Using this functionality in the otel prom exporter fixes a bug where the target_info was prefixed as otelcol_target_info previously. ##### 💡 Enhancements 💡 - `exporter/debug`: Change default `verbosity` from `normal` to `basic` ([#​8844](https://github.com/open-telemetry/opentelemetry-collector/issues/8844)) This change has currently no effect, as `basic` and `normal` verbosity share the same behavior. This might change in the future though, with the `normal` verbosity being more verbose than it currently is (see [https://github.com/open-telemetry/opentelemetry-collector/issues/7806](https://github.com/open-telemetry/opentelemetry-collector/issues/7806)). This is why we are changing the default to `basic`, which is expected to stay at the current level of verbosity (one line per batch). - `exporterhelper`: Fix shutdown logic in persistent queue to not require consumers to be closed first ([#​8899](https://github.com/open-telemetry/opentelemetry-collector/issues/8899)) - `confighttp`: Support proxy configuration field in all exporters that support confighttp ([#​5761](https://github.com/open-telemetry/opentelemetry-collector/issues/5761)) ##### 🧰 Bug fixes 🧰 - `exporterhelper`: Fix invalid write index updates in the persistent queue ([#​8115](https://github.com/open-telemetry/opentelemetry-collector/issues/8115)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ymotongpoo/opentelemetry-collector-extra). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
I support this proposal. |
….90.0 (#28) [![Mend Renovate logo banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [go.opentelemetry.io/collector/consumer](https://github.com/open-telemetry/opentelemetry-collector) | require | minor | `v0.89.0` -> `v0.90.0` | --- ### Release Notes <details> <summary>open-telemetry/opentelemetry-collector (go.opentelemetry.io/collector/consumer)</summary> ### [`v0.90.0`](https://github.com/open-telemetry/opentelemetry-collector/blob/HEAD/CHANGELOG.md#v100v0900) [Compare Source](https://github.com/open-telemetry/opentelemetry-collector/compare/v0.89.0...v0.90.0) ##### 🛑 Breaking changes 🛑 - `service`: To remain backwards compatible w/ the metrics generated today, otel generated metrics will be generated without the `_total` suffix ([#​7454](https://github.com/open-telemetry/opentelemetry-collector/issues/7454)) - `service`: use WithNamespace instead of WrapRegistererWithPrefix ([#​8988](https://github.com/open-telemetry/opentelemetry-collector/issues/8988)) Using this functionality in the otel prom exporter fixes a bug where the target_info was prefixed as otelcol_target_info previously. ##### 💡 Enhancements 💡 - `exporter/debug`: Change default `verbosity` from `normal` to `basic` ([#​8844](https://github.com/open-telemetry/opentelemetry-collector/issues/8844)) This change has currently no effect, as `basic` and `normal` verbosity share the same behavior. This might change in the future though, with the `normal` verbosity being more verbose than it currently is (see [https://github.com/open-telemetry/opentelemetry-collector/issues/7806](https://github.com/open-telemetry/opentelemetry-collector/issues/7806)). This is why we are changing the default to `basic`, which is expected to stay at the current level of verbosity (one line per batch). - `exporterhelper`: Fix shutdown logic in persistent queue to not require consumers to be closed first ([#​8899](https://github.com/open-telemetry/opentelemetry-collector/issues/8899)) - `confighttp`: Support proxy configuration field in all exporters that support confighttp ([#​5761](https://github.com/open-telemetry/opentelemetry-collector/issues/5761)) ##### 🧰 Bug fixes 🧰 - `exporterhelper`: Fix invalid write index updates in the persistent queue ([#​8115](https://github.com/open-telemetry/opentelemetry-collector/issues/8115)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ymotongpoo/opentelemetry-collector-extra). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
….90.0 (#28) [![Mend Renovate logo banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [go.opentelemetry.io/collector/consumer](https://github.com/open-telemetry/opentelemetry-collector) | require | minor | `v0.89.0` -> `v0.90.0` | --- ### Release Notes <details> <summary>open-telemetry/opentelemetry-collector (go.opentelemetry.io/collector/consumer)</summary> ### [`v0.90.0`](https://github.com/open-telemetry/opentelemetry-collector/blob/HEAD/CHANGELOG.md#v100v0900) [Compare Source](https://github.com/open-telemetry/opentelemetry-collector/compare/v0.89.0...v0.90.0) ##### 🛑 Breaking changes 🛑 - `service`: To remain backwards compatible w/ the metrics generated today, otel generated metrics will be generated without the `_total` suffix ([#​7454](https://github.com/open-telemetry/opentelemetry-collector/issues/7454)) - `service`: use WithNamespace instead of WrapRegistererWithPrefix ([#​8988](https://github.com/open-telemetry/opentelemetry-collector/issues/8988)) Using this functionality in the otel prom exporter fixes a bug where the target_info was prefixed as otelcol_target_info previously. ##### 💡 Enhancements 💡 - `exporter/debug`: Change default `verbosity` from `normal` to `basic` ([#​8844](https://github.com/open-telemetry/opentelemetry-collector/issues/8844)) This change has currently no effect, as `basic` and `normal` verbosity share the same behavior. This might change in the future though, with the `normal` verbosity being more verbose than it currently is (see [https://github.com/open-telemetry/opentelemetry-collector/issues/7806](https://github.com/open-telemetry/opentelemetry-collector/issues/7806)). This is why we are changing the default to `basic`, which is expected to stay at the current level of verbosity (one line per batch). - `exporterhelper`: Fix shutdown logic in persistent queue to not require consumers to be closed first ([#​8899](https://github.com/open-telemetry/opentelemetry-collector/issues/8899)) - `confighttp`: Support proxy configuration field in all exporters that support confighttp ([#​5761](https://github.com/open-telemetry/opentelemetry-collector/issues/5761)) ##### 🧰 Bug fixes 🧰 - `exporterhelper`: Fix invalid write index updates in the persistent queue ([#​8115](https://github.com/open-telemetry/opentelemetry-collector/issues/8115)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ymotongpoo/opentelemetry-collector-extra). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…g exporter This is in preparation to implement open-telemetry#7806 (draft PR: open-telemetry#9298).
…g exporter (#9922) This PR is the first part of this draft PR: #9298. This refactoring is needed to implement [[exporter/debug] change behavior of "normal" verbosity to be different from "basic" #7806](#7806). I want to change the behavior of the Debug exporter, but leave the behavior of the Logging exporter unchanged. **Link to tracking Issue:** - #7806
Proposing changes to change the formatting in |
…ty (#10225) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Changes the behavior of `normal` verbosity of the Debug exporter for logs to display each log record in one line of text. Note that if the body of the log record contains newlines, the output will be displayed in multiple lines. This pull request is part of #7806; it implements the change for logs. The changes for metrics and [traces](#10280) will be proposed in separate pull requests. The implementation in this pull request does not display any details on the resource or the scope of the logs. I would like to propose displaying the resource and the scope as separate lines in a separate pull request. This change applies to the Debug exporter only. The behavior of the Logging exporter remains unchanged. To use this behavior, switch from the deprecated Logging exporter to Debug exporter. #### Link to tracking issue - #7806 #### Testing Added unit tests for the formatter. #### Documentation Described the formatting in the Debug exporter's README. --------- Co-authored-by: Roger Coll <roger.coll@elastic.co> Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
…0280) #### Description This is an initial barebones implementation that only outputs the span's name, trace ID and span ID. Other useful fields like duration etc. can be added in follow-up enhancements. This pull request is part of #7806; it implements the change for traces. The changes for [logs](#10225) and metrics will be proposed in separate pull requests. This change applies to the Debug exporter only. The behavior of the Logging exporter remains unchanged. To use this behavior, switch from the deprecated Logging exporter to Debug exporter. #### Link to tracking issue - #7806 #### Testing Added unit tests for the formatter. #### Documentation Described the formatting in the Debug exporter's README. --------- Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
…verbosity (#10462) #### Description This pull request is part of #7806; it implements the change for metrics. The changes for [logs](#10225) and [traces](#10280) have been proposed in separate pull requests. This change applies to the Debug exporter only. The behavior of the Logging exporter remains unchanged. To use this behavior, switch from the deprecated Logging exporter to Debug exporter. #### Link to tracking issue - #7806 #### Testing Added unit tests for the formatter. #### Documentation Described the formatting in the Debug exporter's README.
Given that all these PRs are merged, I'm closing this issue. |
EDIT: Updated the issue to change the
debug
exporter instead oflogging
exporter.Collector version: v0.88.0
Is your feature request related to a problem? Please describe.
Currently there are three verbosity levels available for the Debug exporter:
basic
,normal
,detailed
. Thebasic
andnormal
level result in the same output, which only displays the number of records:2023-06-01T13:26:16.044+0200 info MetricsExporter {"kind": "exporter", "data_type": "metrics", "name": "logging", "resource metrics": 1, "metrics": 1, "data points": 1}
On the other hand, the
detailed
verbosity displays all the details about telemetry, with multiple lines per span/data point/log record:Describe the solution you'd like
I propose to change the behavior for the
normal
verbosity to display telemetry details one line per span/data point/log record:The format is up for discussion, but I believe having one line per telemetry record might be a good "middle ground". The resource and scope details might or might not also be displayed, I'm open to suggestions.
Describe alternatives you've considered
I considered using the File exporter, which outputs JSON with full information on the telemetry to a file.
Another alternative for metrics is to use Prometheus exporter, but it modifies data (replaces dots with underscores etc.).
The text was updated successfully, but these errors were encountered: