[chore] migrate obsreport to use errors.Join instead of go.uber.org/multierr #8223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivanshuraj1333
changed the title
6 tasks
shivanshuraj1333
force-pushed
the
feat/issues/8210
branch
from
cc25466
to
5e26371
Compare
shivanshuraj1333
changed the title
dmitryax
reviewed
Aug 15, 2023
| @@ -89,37 +88,37 @@ func (exp *Exporter) createOtelMetrics(cfg ExporterSettings) error { | |||
| obsmetrics.ExporterPrefix+obsmetrics.SentSpansKey, | |||
| metric.WithDescription("Number of spans successfully sent to destination."), | |||
| metric.WithUnit("1")) | |||
| errors = multierr.Append(errors, err) | |||
| errors = errors.Join(errors, err) | |||
There was a problem hiding this comment.
Please rename variable errors to not clash with the package name
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #8210