Allow any registered gRPC load balancer to be used #8262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #8262 +/- ##
==========================================
- Coverage 90.18% 90.14% -0.04%
==========================================
Files 302 302
Lines 15766 15771 +5
==========================================
- Hits 14218 14217 -1
- Misses 1254 1259 +5
- Partials 294 295 +1
☔ View full report in Codecov by Sentry. |
bogdandrutu
approved these changes
Aug 22, 2023
|
@jmacd please add a changelog about this enhancement |
|
Apologies, i accidentally closed the PR on github from my phone 😬 |
|
I made a changelog, but there's no issue filed and it makes me think this PR doesn't really need a changelog entry. Do we need an issue? |
|
I'll file an issue stating that changelog issues shouldn't require issues, though :) |
jmacd
force-pushed
the
jmacd/any_balancer
branch
from
fa4fbb2
to
36b9475
Compare
codeboten
approved these changes
Aug 23, 2023
|
Looks like one linting error to address: |
|
@jmacd why do you hate linters? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: gRPC-Go's
balancerpackage includes a static registration mechanism and a way to inspect whether a balancer name is registered. We should use this mechanism instead of hard-coding an allowlist of balancer names.Custom collector configurations may have additional balancers linked in, and we should allow them to be used.
Testing: existing cover this, pass
Documentation: Existing documentation refers to gRPC balancer package, does not mention any allowlist behavior.