Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List valid feature gates when failing to load invalid gate #8505

Merged
merged 1 commit into from
Sep 22, 2023
Merged

List valid feature gates when failing to load invalid gate #8505

merged 1 commit into from
Sep 22, 2023

Conversation

djaglowski
Copy link
Member

@djaglowski djaglowski commented Sep 22, 2023 •
edited
Loading

I found myself troubleshooting an issue with a feature gate not being accepted and found this to be helpful.

Usage:

./bin/otelcorecol --feature-gates=fake
Error: invalid argument "fake" for "--feature-gates" flag: no such feature gate "fake". valid gates: [confmap.expandEnabled telemetry.disableHighCardinalityMetrics telemetry.useOtelForInternalMetrics telemetry.useOtelWithSDKConfigurationForInternalTelemetry]

@djaglowski djaglowski changed the title Log valid feature gates on error List valid feature gates when failing to load invalid gate Sep 22, 2023
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed Coverage
featuregate/registry.go 100.00%

📢 Thoughts on this report? Let us know!.

@djaglowski djaglowski marked this pull request as ready for review September 22, 2023 15:50
@djaglowski djaglowski requested review from a team and bogdandrutu September 22, 2023 15:50
codeboten
codeboten approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍🏻

@codeboten codeboten merged commit b8eb083 into open-telemetry:main Sep 22, 2023
34 of 35 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 22, 2023
@djaglowski djaglowski deleted the log-featuregates branch September 22, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.86.0
Development

Successfully merging this pull request may close these issues.
2 participants
@djaglowski @codeboten