Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmd/builder] Log output from go subcommands #8715

Merged
merged 5 commits into from
Nov 6, 2023

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Oct 20, 2023

Description:

Log output from go subcommands being ran as part of an ocb build.

@mx-psi mx-psi marked this pull request as ready for review October 20, 2023 12:36
@mx-psi mx-psi requested review from a team and codeboten October 20, 2023 12:36
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Files Coverage Δ
cmd/builder/internal/builder/config.go 65.95% <ø> (ø)
cmd/builder/internal/command.go 62.23% <100.00%> (+0.26%) ⬆️
cmd/builder/internal/builder/main.go 54.12% <29.16%> (-5.68%) ⬇️

📢 Thoughts on this report? Let us know!.

@mx-psi mx-psi requested a review from codeboten October 24, 2023 15:08
@codeboten
Copy link
Contributor

@mx-psi some linting needed:

internal/builder/main.go:137: File is not `gofmt`-ed with `-s` (gofmt)
  
  if err := runGoCommand(cfg, "mod", "tidy", "-compat=1.20"); err != nil {

@mx-psi mx-psi merged commit 00c6dec into open-telemetry:main Nov 6, 2023
31 of 32 checks passed
@mx-psi mx-psi deleted the mx-psi/logging-builder branch November 6, 2023 13:08
@github-actions github-actions bot added this to the next release milestone Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants