[chore] Fix flaky test TestPersistentQueue_FullCapacity #8980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Another fix for flaky test TestPersistentQueue_FullCapacity. We need to make sure that the first item left consumed from the queue before proceeding. Otherwise, it can ocasionally fail with:
```
--- FAIL: TestPersistentQueue_FullCapacity (0.00s)
persistent_queue_test.go:91:
Error Trace: /home/runner/work/opentelemetry-collector/opentelemetry-collector/exporter/exporterhelper/internal/persistent_queue_test.go:91
Error: Received unexpected error:
sending queue is full
Test: TestPersistentQueue_FullCapacity
FAIL
```
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8980 +/- ##
=======================================
Coverage 91.55% 91.55%
=======================================
Files 316 316
Lines 17111 17111
=======================================
Hits 15666 15666
Misses 1150 1150
Partials 295 295 ☔ View full report in Codecov by Sentry. |
mx-psi
approved these changes
Nov 22, 2023
pantuza
pushed a commit
to pantuza/opentelemetry-collector
that referenced
this pull request
Dec 8, 2023
…ry#8980) Another fix for the flaky test `TestPersistentQueue_FullCapacity`. We need to make sure that the first item is consumed from the queue before proceeding. Otherwise, it can occasionally fail with: ``` --- FAIL: TestPersistentQueue_FullCapacity (0.00s) persistent_queue_test.go:91: Error Trace: /home/runner/work/opentelemetry-collector/opentelemetry-collector/exporter/exporterhelper/internal/persistent_queue_test.go:91 Error: Received unexpected error: sending queue is full Test: TestPersistentQueue_FullCapacity FAIL ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another fix for the flaky test
TestPersistentQueue_FullCapacity. We need to make sure that the first item is consumed from the queue before proceeding. Otherwise, it can occasionally fail with: