Fix code detecting if the collector is running as service on Windows #9035
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Re-instate change #4253 (it seems that it was lost by accident). The deprecated function being called checks if the process is an interactive process, however, while services are non-interactive the reverse is not true: a process can be non-interactive but not a service. This is what caused the detection to fail and required the use of
NO_WINDOWS_SERVICE
, with this change there should be no need for this variable anymore. If the SIG decide to deprecate this environment variable it should be done in a separate change.Link to tracking Issue:
Fix #7350: it will be fixed since the detection should work correctly from this point forward.
Testing:
Local run of the collector.
Documentation:
Update changelog.