Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[builder] Close files immediately after writing is complete #9466

Conversation

pjanotti
Copy link
Contributor

@pjanotti pjanotti commented Feb 5, 2024

Description:
Ensure that files written by cmd/builder are closed right after their content is written. This came about while investigating #5403

Link to tracking Issue:
#5403

Testing:
Local run on Windows

Documentation:
N/A

@pjanotti pjanotti requested review from a team and Aneurysm9 February 5, 2024 22:01
@atoulme atoulme added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Feb 5, 2024
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fa1b241) 90.44% compared to head (3f3cf9f) 90.42%.
Report is 6 commits behind head on main.

❗ Current head 3f3cf9f differs from pull request most recent head 2033c18. Consider uploading reports for the commit 2033c18 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9466      +/-   ##
==========================================
- Coverage   90.44%   90.42%   -0.02%     
==========================================
  Files         346      346              
  Lines       18106    18107       +1     
==========================================
- Hits        16376    16374       -2     
- Misses       1399     1401       +2     
- Partials      331      332       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codeboten codeboten merged commit c1cb275 into open-telemetry:main Feb 6, 2024
41 of 44 checks passed
@pjanotti pjanotti deleted the close-files-on-windows-after-generate-done branch February 6, 2024 19:22
@github-actions github-actions bot added this to the next release milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants