Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Remove the top level error if it indicates an empty name #9763

Merged

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Mar 14, 2024

This is a split of #9750 that tries to work around mapstructure, which wraps an error around a decoding error.

In the case when an error is returned from a top level construct, we get a not so helpful message that says:

error decoding '': error running encode hook: marshaling error

With this change, the error is unwrapped, giving the following string representation:

error running encode hook: marshaling error

Because #9750 enforces going through mapstructure, it would change errors returned with this not-so-helpful preamble. Adding this removes the problem.

@atoulme atoulme requested review from a team and mx-psi March 14, 2024 20:08
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.99%. Comparing base (7198451) to head (4046323).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9763   +/-   ##
=======================================
  Coverage   90.99%   90.99%           
=======================================
  Files         353      353           
  Lines       18614    18621    +7     
=======================================
+ Hits        16937    16944    +7     
  Misses       1352     1352           
  Partials      325      325           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmitryax dmitryax merged commit c62b80d into open-telemetry:main Mar 14, 2024
46 checks passed
@github-actions github-actions bot added this to the next release milestone Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants