metrics warnings (#1583)

open-telemetry · Aug 28, 2022 · 5788287 · 5788287 · github-actions · Aug 28, 2022
1 parent 1f37839
commit 5788287
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/sdk/include/opentelemetry/sdk/metrics/instruments.h b/sdk/include/opentelemetry/sdk/metrics/instruments.h
@@ -4,6 +4,7 @@
 #pragma once
 #ifndef ENABLE_METRICS_PREVIEW
 #  include <functional>
+#  include "opentelemetry/common/macros.h"
 #  include "opentelemetry/sdk/common/attribute_utils.h"
 OPENTELEMETRY_BEGIN_NAMESPACE
 namespace sdk
@@ -61,7 +62,7 @@ struct InstrumentDescriptor
 
 using MetricAttributes               = opentelemetry::sdk::common::OrderedAttributeMap;
 using AggregationTemporalitySelector = std::function<AggregationTemporality(InstrumentType)>;
-static InstrumentClass GetInstrumentClass(InstrumentType type)
+OPENTELEMETRY_MAYBE_UNUSED static InstrumentClass GetInstrumentClass(InstrumentType type)
 {
   if (type == InstrumentType::kCounter || type == InstrumentType::kHistogram ||
       type == InstrumentType::kUpDownCounter)

diff --git a/sdk/test/metrics/async_metric_storage_test.cc b/sdk/test/metrics/async_metric_storage_test.cc
@@ -98,7 +98,6 @@ TEST_P(WritableMetricStorageTestFixture, TestAggregation)
   std::shared_ptr<CollectorHandle> collector(new MockCollectorHandle(temporality));
   std::vector<std::shared_ptr<CollectorHandle>> collectors;
   collectors.push_back(collector);
-  size_t count_attributes = 0;
 
   std::unique_ptr<AttributesProcessor> default_attributes_processor{
       new DefaultAttributesProcessor{}};

diff --git a/sdk/test/metrics/metric_reader_test.cc b/sdk/test/metrics/metric_reader_test.cc
@@ -27,7 +27,6 @@ class MockMetricReader : public MetricReader
 
 TEST(MetricReaderTest, BasicTests)
 {
-  AggregationTemporality aggr_temporality = AggregationTemporality::kDelta;
   std::unique_ptr<MetricReader> metric_reader1(new MockMetricReader());
   EXPECT_EQ(metric_reader1->GetAggregationTemporality(InstrumentType::kCounter),
             AggregationTemporality::kCumulative);
Benchmark suite	Current: `5788287`	Previous: `1f37839`	Ratio
`BM_ProcYieldSpinLockThrashing/1/process_time/real_time`	`0.24560122262863887` ms/iter	`0.11119767436831016` ms/iter	`2.21`
`BM_NaiveSpinLockThrashing/1/process_time/real_time`	`0.6419114878612199` ms/iter	`0.1110088769607188` ms/iter	`5.78`