Skip to content

Commit

Permalink
Fix build warnings about missing aggregates. (#1368)
Browse files Browse the repository at this point in the history
  • Loading branch information
taekahn authored Jul 1, 2022
1 parent 45fdbf2 commit 7b0bb14
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions sdk/src/trace/samplers/trace_id_ratio.cc
Original file line number Diff line number Diff line change
Expand Up @@ -92,14 +92,14 @@ SamplingResult TraceIdRatioBasedSampler::ShouldSample(
const trace_api::SpanContextKeyValueIterable & /*links*/) noexcept
{
if (threshold_ == 0)
return {Decision::DROP, nullptr};
return {Decision::DROP, nullptr, {}};

if (CalculateThresholdFromBuffer(trace_id) <= threshold_)
{
return {Decision::RECORD_AND_SAMPLE, nullptr};
return {Decision::RECORD_AND_SAMPLE, nullptr, {}};
}

return {Decision::DROP, nullptr};
return {Decision::DROP, nullptr, {}};
}

nostd::string_view TraceIdRatioBasedSampler::GetDescription() const noexcept
Expand Down

1 comment on commit 7b0bb14

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'OpenTelemetry-cpp api Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 7b0bb14 Previous: 45fdbf2 Ratio
BM_ProcYieldSpinLockThrashing/2/process_time/real_time 0.4708900280980189 ms/iter 0.21469011539366187 ms/iter 2.19

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.