[ETW Exporter]Do not overwrite ParentId when setting attribute on Span (

#1989)
open-telemetry · Feb 18, 2023 · 95f6c66 · 95f6c66
1 parent 01eac4c
commit 95f6c66
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -15,6 +15,8 @@ Increment the:
 
 ## [Unreleased]
 
+* ETW Exporter]Do not overwrite ParentId when setting attribute on Span
+  [#1989](https://github.com/open-telemetry/opentelemetry-cpp/pull/1989)
 * Convert Prometheus Exporter to Pull MetricReader [#1953](https://github.com/open-telemetry/opentelemetry-cpp/pull/1953)
 * Upgrade prometheus-cpp to v1.1.0 [#1954](https://github.com/open-telemetry/opentelemetry-cpp/pull/1954)
 * [BUILD] Build OpenTelemetry SDK and exporters into DLL

diff --git a/exporters/etw/include/opentelemetry/exporters/etw/etw_tracer.h b/exporters/etw/include/opentelemetry/exporters/etw/etw_tracer.h
@@ -870,7 +870,8 @@ class Span : public opentelemetry::trace::Span
   void SetAttribute(nostd::string_view key, const common::AttributeValue &value) noexcept override
   {
     // don't override fields propagated from span data.
-    if (key == ETW_FIELD_NAME || key == ETW_FIELD_SPAN_ID || key == ETW_FIELD_TRACE_ID)
+    if (key == ETW_FIELD_NAME || key == ETW_FIELD_SPAN_ID || key == ETW_FIELD_TRACE_ID ||
+        key == ETW_FIELD_SPAN_PARENTID)
     {
       return;
     }