-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move implementation from SDK header files to SDK *.cc #1429
Labels
Comments
3 tasks
lalitb
added
good first issue
Good for newcomers
help wanted
Good for taking. Extra help will be provided by maintainers
labels
Jun 3, 2022
lalitb
removed
help wanted
Good for taking. Extra help will be provided by maintainers
good first issue
Good for newcomers
labels
Jul 18, 2022
As discussed in community meeting, expanding the scope from "moving static variables to *.cc" to "moving all code to *.cc". |
marcalff
changed the title
Move static variables from SDK header files to SDK *.cc
Move implementation from SDK header files to SDK *.cc
Jul 21, 2022
This issue was marked as stale due to lack of activity. |
This issue was marked as stale due to lack of activity. |
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
This is a remaining item identified during review of PR #1420
For all the static variables found in SDK header files,
consider (to discuss) to either:
List of variables identified:
File
opentelemetry/sdk/common/empty_attributes.h
File
opentelemetry/sdk/metrics/aggregation/drop_aggregation.h
File
opentelemetry/sdk/metrics/exemplar/always_sample_filter.h
File
opentelemetry/sdk/metrics/view/view_registry.h
File
opentelemetry/sdk/resource/experimental_semantic_conventions.h
This one (
attribute_ids
) probably needs more investigation before doing any changes (strings resolved at compile time or runtime ?).File
opentelemetry/sdk/trace/multi_recordable.h
File
opentelemetry/sdk/trace/span_data.h
Code cleanup, low priority.
The text was updated successfully, but these errors were encountered: