-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUILD] shared libraries with version suffix, along with the symbolic link #2109
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2109 +/- ##
==========================================
- Coverage 87.19% 87.17% -0.02%
==========================================
Files 166 166
Lines 4784 4784
==========================================
- Hits 4171 4170 -1
- Misses 613 614 +1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using OPENTELEMETRY_ABI_VERSION_NO as SOVERSION looks like the correct choice.
See minor comment on dependent options.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
To clarify, I don't think opentelemetry-cpp is ready to use shared libraries yet.
We need to make sure the proper symbol is part of the proper library, see issue #1429.
This is however a different issue, which should not prevent this part to go in the main branch.
Ok to merge.
Fixes #2100
Changes
Versioning policy is described here for debian - https://www.debian.org/doc/debian-policy/ch-sharedlibs.html. In general same is followed across other *nix distributions.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes