ETW Log Exporter #1006
Merged
ETW Log Exporter #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1006 +/- ##
=======================================
Coverage 95.41% 95.41%
=======================================
Files 161 161
Lines 6833 6833
=======================================
Hits 6519 6519
Misses 314 314 |
|
Removing WIP, as it is ready for review. |
ThomsonTan
reviewed
Oct 5, 2021
| bool enableActivityTracking; // Emit TraceLogging events for Span/Start and Span/Stop Not used | ||
| // for Logs | ||
| bool enableRelatedActivityId; // Assign parent `SpanId` to `RelatedActivityId` | ||
| bool enableAutoParent; // Start new spans as children of current active span, Not used for Logs |
There was a problem hiding this comment.
nit: keep alignment of comments?
There was a problem hiding this comment.
clang-format tool format this way to keep under configured line limit :)
opentelemetry-cpp/.clang-format
Line 11 in 2f462a5
ThomsonTan
reviewed
Oct 6, 2021
ThomsonTan
reviewed
Oct 6, 2021
ThomsonTan
reviewed
Oct 6, 2021
ThomsonTan
reviewed
Oct 6, 2021
Co-authored-by: Tom Tan <lilotom@gmail.com>
Co-authored-by: Tom Tan <lilotom@gmail.com>
Co-authored-by: Tom Tan <lilotom@gmail.com>
Co-authored-by: Tom Tan <lilotom@gmail.com>
ThomsonTan
approved these changes
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds ETW Log exporter using the current preview Logger API.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes