Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract foo library into a separate library #1043

Merged
merged 4 commits into from
Oct 30, 2021
Merged

Extract foo library into a separate library #1043

merged 4 commits into from
Oct 30, 2021

Conversation

esigo
Copy link
Member

@esigo esigo commented Oct 29, 2021

Fixes #907 (issue)

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@esigo esigo requested a review from a team October 29, 2021 22:33
@codecov
Copy link

codecov bot commented Oct 29, 2021 •
edited
Loading

Codecov Report

Merging #1043 (f873929) into main (838d962) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1043   +/-   ##
=======================================
  Coverage   94.85%   94.85%           
=======================================
  Files         151      151           
  Lines        5972     5972           
=======================================
  Hits         5664     5664           
  Misses        308      308

lalitb
lalitb approved these changes Oct 29, 2021
View reviewed changes
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor comments. Thanks for the PR.

examples/CMakeLists.txt
@@ -1,3 +1,4 @@
add_subdirectory(common)
Copy link
Member

@lalitb lalitb Oct 29, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: we can also add include_directories(common) here, and remove the dependency from subfolders ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good one, thanks

examples/common/foo_library/BUILD Outdated Show resolved Hide resolved
@lalitb lalitb merged commit af75379 into open-telemetry:main Oct 30, 2021
@esigo esigo deleted the Extract-foo_library-into-a-separate-library branch October 30, 2021 05:59
@esigo esigo mentioned this pull request Nov 23, 2021
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lalitb lalitb lalitb approved these changes

@ThomsonTan ThomsonTan ThomsonTan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extract foo_library into a separate library
3 participants
@esigo @ThomsonTan @lalitb