build release tarball when nlohmann-json not installed #1074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1074 +/- ##
=======================================
Coverage 94.41% 94.41%
=======================================
Files 158 158
Lines 6077 6077
=======================================
Hits 5737 5737
Misses 340 340 |
esigo
changed the title
esigo
changed the title
lalitb
reviewed
Nov 18, 2021
exporters/otlp/CMakeLists.txt
Outdated
| if(nlohmann_json_clone) | ||
| add_dependencies(opentelemetry_exporter_otlp_http_client | ||
| nlohmann_json::nlohmann_json) | ||
| list(APPEND OPENTELEMETRY_OTLP_TARGETS nlohmann_json_) |
There was a problem hiding this comment.
it's needed for install. nlohmann_json::nlohmann_json is an alias for nlohmann_json_ here.
There was a problem hiding this comment.
ok, thanks. Should that be an install target for Zipkin and ETW too, or else just have it in cmake/nlohmann-json.cmake ?
lalitb
approved these changes
Nov 18, 2021
ThomsonTan
approved these changes
Nov 19, 2021
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #981 (issue)
Changes
Please provide a brief description of the changes here.
clones nlohmann-json if not present in third_party folder.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes