Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark tags to bazel targets #1075

Merged
merged 5 commits into from
Nov 22, 2021

Conversation

esigo
Copy link
Member

@esigo esigo commented Nov 18, 2021

Fixes #1072 (issue)

Changes

mark tags to bazel targets.

Please provide a brief description of the changes here.
can exclude targets e.g.
bazel build //... --build_tag_filters=-otlp,-es,-etw,-prometheus,-zipkin
For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@esigo esigo requested a review from a team November 18, 2021 09:09
@codecov
Copy link

codecov bot commented Nov 18, 2021

Codecov Report

Merging #1075 (822700e) into main (9e8be67) will not change coverage.
The diff coverage is n/a.

❗ Current head 822700e differs from pull request most recent head c78b842. Consider uploading reports for the commit c78b842 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1075   +/-   ##
=======================================
  Coverage   94.41%   94.41%           
=======================================
  Files         158      158           
  Lines        6077     6077           
=======================================
  Hits         5737     5737           
  Misses        340      340           

@lalitb
Copy link
Member

lalitb commented Nov 22, 2021

Thanks for adding it. Just thinking if we can we also add separate tags for:

  • API ( this would be helpful for the instrumentation-only build, similar to what we do through cmake here )
  • Separate tags for otlp_grpc and otlp_http ?
  • Tags for tests and/or examples, to provide way to filter building tests and examples.

It's fine to add it separate from this PR if this is a bigger task ( or raise a github issue for someone to pick it up ).

@esigo
Copy link
Member Author

esigo commented Nov 22, 2021

Thanks for adding it. Just thinking if we can we also add separate tags for:

  • API ( this would be helpful for the instrumentation-only build, similar to what we do through cmake here )
  • Separate tags for otlp_grpc and otlp_http ?
  • Tags for tests and/or examples, to provide way to filter building tests and examples.

It's fine to add it separate from this PR if this is a bigger task ( or raise a github issue for someone to pick it up ).

@lalitb thanks for the feedback.
Yeah sounds good. Let's merge this. I'll raise a separate PR to cover the rest.

@ThomsonTan ThomsonTan merged commit 0a924fb into open-telemetry:main Nov 22, 2021
@esigo esigo deleted the Mark-tags-to-bazel-targets branch December 4, 2021 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mark tags to bazel targets
3 participants