Jaeger bazel (Linux only) #1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1077 +/- ##
=======================================
Coverage 94.41% 94.41%
=======================================
Files 158 158
Lines 6077 6077
=======================================
Hits 5737 5737
Misses 340 340 |
|
Sorry for the delay in reviewing this. would try to review it by today. |
lalitb
approved these changes
Nov 25, 2021
| url = "https://github.com/bazelbuild/rules_foreign_cc/archive/0.6.0.tar.gz", | ||
| ) | ||
|
|
||
| load("@rules_foreign_cc//foreign_cc:repositories.bzl", "rules_foreign_cc_dependencies") |
There was a problem hiding this comment.
Can we use rules_foreign_cc to build and install boost library too - if that helps to support for Windows? Probably, we can create a github issue for Windows support, for someone to pick it up.
There was a problem hiding this comment.
Sure, I'll raise another PR for Windows support.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jaeger bazel support
Changes
Adds Jaeger bazel support.
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes