Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove missing target in legacy prometheus #1097

Merged
merged 3 commits into from
Nov 25, 2021
Merged

Conversation

owent
Copy link
Member

@owent owent commented Nov 24, 2021

Signed-off-by: owentou owentou@tencent.com

Fixes #1096

Changes

Remove missing target and fix document for exported config file.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

Signed-off-by: owentou <owentou@tencent.com>
@owent owent requested a review from a team November 24, 2021 08:01
@codecov
Copy link

codecov bot commented Nov 24, 2021

Codecov Report

Merging #1097 (58edf22) into main (1867688) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1097   +/-   ##
=======================================
  Coverage   94.41%   94.41%           
=======================================
  Files         158      158           
  Lines        6077     6077           
=======================================
  Hits         5737     5737           
  Misses        340      340           

Signed-off-by: owentou <owentou@tencent.com>
Signed-off-by: owentou <owentou@tencent.com>
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, looks like it got introduced while deprecating the old matrix implementation. Not related to this PR, but I feel it would be good to add the cmake install test too in the CI pipeline to catch these errors.

@owent
Copy link
Member Author

owent commented Nov 25, 2021

Thanks for fixing this, looks like it got introduced while deprecating the old matrix implementation. Not related to this PR, but I feel it would be good to add the cmake install test too in the CI pipeline to catch these errors.

Need use prebuilt prometheus-cpp to catch this problem. It maybe will take a long time to build all dependencies.
In https://github.com/atframework/cmake-toolset/actions/runs/1499413005, it takes about 50 minutes to finish the job, most package in it is the dependencies of opentelemetry-cpp. So I wonder if we should do the same thing here, or should we cache the prebuilt files when the versions of dependencies not changed?

@lalitb
Copy link
Member

lalitb commented Nov 25, 2021

Need use prebuilt prometheus-cpp to catch this problem.

I am not completely sure if that would have helped here. As I understand, the missing target error would have got caught during the otel-cpp installation, which we don't do in our CI pipeline.
But to speed up the CI pipeline, I feel it would be good to use some form of caching ( either using pre-built binaries of external dependencies as you mentioned or using cmake cache).
While I would merge this PR, we can continue discussing in this thread for any optimization we can do to speed-up pipeline.

@lalitb lalitb merged commit 1e1fb8b into open-telemetry:main Nov 25, 2021
@owent owent deleted the fix_1096 branch December 13, 2021 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not build with cmake when enable prometheus exporter
2 participants