Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run_docker user #1123

Merged
merged 3 commits into from
Dec 10, 2021
Merged

run_docker user #1123

merged 3 commits into from
Dec 10, 2021

Conversation

esigo
Copy link
Member

@esigo esigo commented Dec 9, 2021

Fixes file permission change after using ./ci/run_docker.sh tools/format.sh

Changes

by running the container with the current user id and group id we can avoid file permission change after running the script.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@esigo esigo requested a review from a team December 9, 2021 21:32
@codecov
Copy link

codecov bot commented Dec 9, 2021

Codecov Report

Merging #1123 (07ba668) into main (5e258b0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1123   +/-   ##
=======================================
  Coverage   93.39%   93.39%           
=======================================
  Files         165      165           
  Lines        6229     6229           
=======================================
  Hits         5817     5817           
  Misses        412      412           

@lalitb lalitb merged commit 836dda6 into open-telemetry:main Dec 10, 2021
@esigo esigo deleted the run_docker-user branch December 28, 2021 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants