Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jaeger exporter shutdown #1150

Merged
merged 3 commits into from
Dec 19, 2021
Merged

Jaeger exporter shutdown #1150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
97a948e
Jaeger exporter Shutdown
esigo Dec 18, 2021
8dee883
Revert "Jaeger exporter Shutdown"
esigo Dec 18, 2021
19aa567
Jaeger exporter Shutdown
esigo Dec 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions exporters/jaeger/include/opentelemetry/exporters/jaeger/jaeger_exporter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,7 @@ class JaegerExporter final : public opentelemetry::sdk::trace::SpanExporter
* @param timeout an option timeout, default to max.
*/
bool Shutdown(
std::chrono::microseconds timeout = std::chrono::microseconds::max()) noexcept override
{
return true;
}
std::chrono::microseconds timeout = std::chrono::microseconds::max()) noexcept override;

private:
void InitializeEndpoint();
Expand Down
6 changes: 6 additions & 0 deletions exporters/jaeger/src/jaeger_exporter.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,12 @@ void JaegerExporter::InitializeEndpoint()
assert(false);
}

bool JaegerExporter::Shutdown(std::chrono::microseconds timeout) noexcept
{
is_shutdown_ = true;
return true;
}

} // namespace jaeger
} // namespace exporter
OPENTELEMETRY_END_NAMESPACE