-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the Google naming convention. #12
Conversation
We discussed this during today's SIG meeting. |
Can change this to refer just to the Google naming convention, not the full style guide? What I though we agreed to was core guidelines for the style guide and the google naming convention (since core guidelines doesn't have one) |
@rnburn I'd like to apply most of the style guide, e.g. Output Parameters. How should I change the wording? Also, we should document exceptions like:
|
Can we limit this PR to just what we agreed to on the call (which was the naming convention)? Maybe don't use it to close #5 if you want to further debate the non-naming parts of a style guide. I would prefer to take CppCore guideline over Google style guide for other parts (they use references for Output parameters). |
Ah, ok. I've updated the PR. Not closing #5. |
Please remind me: how many approvals do I need before it's okay to merge? :) |
|
…tors Origin/propagators
[DOC] Fix OTLP documentation: Default endpoint is wrong for OTLP/HTTP…
Part of #5.