Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update grpc to v1.43.2 to support VS2022/MSVC 19.30 and bazel 5.0 #1207

Merged
merged 1 commit into from
Feb 15, 2022

Conversation

owent
Copy link
Member

@owent owent commented Feb 13, 2022

Signed-off-by: owent admin@owent.net

Fixes #1206

Changes

Upgrade grpc to v1.43.2

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@owent owent requested a review from a team February 13, 2022 06:04
@codecov
Copy link

codecov bot commented Feb 13, 2022

Codecov Report

Merging #1207 (3c61cc5) into main (9ed312b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1207   +/-   ##
=======================================
  Coverage   93.35%   93.35%           
=======================================
  Files         193      193           
  Lines        6908     6908           
=======================================
  Hits         6448     6448           
  Misses        460      460           

@lalitb
Copy link
Member

lalitb commented Feb 15, 2022

@owent - can you rebase it to main, to enable merge. Thanks.

@owent
Copy link
Member Author

owent commented Feb 15, 2022

Done

@lalitb lalitb merged commit 15c6f33 into open-telemetry:main Feb 15, 2022
@owent owent deleted the fix_1206 branch April 3, 2022 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not build with MSVC 19.30(VS2022) and bazel 5.0
4 participants