Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the default size of FD_SETSIZE #1477

Closed
wants to merge 1 commit into from

Conversation

ThomsonTan
Copy link
Contributor

Fixes #1476.

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@ThomsonTan ThomsonTan requested a review from a team July 5, 2022 22:33
@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #1477 (0548de7) into main (9efb7a1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1477   +/-   ##
=======================================
  Coverage   85.31%   85.31%           
=======================================
  Files         154      154           
  Lines        4377     4377           
=======================================
  Hits         3734     3734           
  Misses        643      643           
Impacted Files Coverage Δ
...lemetry/ext/http/client/curl/http_operation_curl.h 77.64% <ø> (ø)

@lalitb
Copy link
Member

lalitb commented Jul 5, 2022

Just wondering if the issue would be still valid once @owent async changes are merged, as that PR removes select call usage. Also, there was similar fix done for Linux - #1410 to replace select call with poll. If there is similar alternative for Windows ?

@ThomsonTan
Copy link
Contributor Author

Just wondering if the issue would be still valid once @owent async changes are merged, as that PR removes select call usage. Also, there was similar fix done for Linux - #1410 to replace select call with poll. If there is similar alternative for Windows ?

@lalitb thanks for the reminder. Yes, the async change will remove current code with issue, so I think I could close this PR once the async change is merged. Also I think #1410 applies to Windows as well, right?

@lalitb
Copy link
Member

lalitb commented Jul 5, 2022

Also I think #1410 applies to Windows as well, right?

#1410 replaces select with poll only for POSIX and keeps select for Windows. Merging this PR will add more conflict with async PR. If this is not the blocker, we can let @owent to decide how to proceed with this PR?

@ThomsonTan
Copy link
Contributor Author

Ok. I'll just leave this PR open and will close it once the async change from @owent gets merged, no need for merging.

@owent
Copy link
Member

owent commented Jul 6, 2022

libcurl use select on WIndows and poll on Linux, just like #1410 . According to https://docs.microsoft.com/en-us/windows/win32/api/winsock2/nf-winsock2-select, nfds of select on Windows is just ignored. I think we can wait for #1413 to be merged. Or we can just ignore max_fd checking on Windows.

@ThomsonTan ThomsonTan closed this Jul 9, 2022
@ThomsonTan ThomsonTan deleted the FixFD_SETSIZE branch November 9, 2022 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The default value of FD_SETSIZE is too small for real scenario
3 participants