Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metrics] Add OTLP http metric exporter #1487

Merged
merged 7 commits into from
Jul 19, 2022
Merged

[Metrics] Add OTLP http metric exporter #1487

merged 7 commits into from
Jul 19, 2022

Conversation

owent
Copy link
Member

@owent owent commented Jul 11, 2022 •
edited
Loading

Fixes #1371

Changes

  • Add OTLP HTTP Metrics exporter
    • CMake target
    • Bazel target
  • Unit test
  • Add Shutdown test for all OTLP HTTP exporters
  • Add ForceFlush for OtlpHttpClient
  • Add Gauge support for OtlpMetricUtils::PopulateRequest

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@owent owent requested a review from a team July 11, 2022 09:24
@codecov
Copy link

codecov bot commented Jul 11, 2022 •
edited
Loading

Codecov Report

Merging #1487 (4fe3069) into main (4062237) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1487      +/-   ##
==========================================
- Coverage   84.72%   84.66%   -0.06%     
==========================================
  Files         156      156              
  Lines        4784     4784              
==========================================
- Hits         4053     4050       -3     
- Misses        731      734       +3
Impacted Files Coverage Δ
ext/src/http/client/curl/http_client_curl.cc 79.93% <0.00%> (-1.13%) ⬇️

@lalitb lalitb mentioned this pull request Jul 12, 2022
Closed
@owent owent force-pushed the otlp_metrics_exporter branch 2 times, most recently from 26a6826 to 456bd6c Compare July 13, 2022 04:59
@owent owent changed the title [WIP] Add OTLP http metric exporter [Metrics] Add OTLP http metric exporter Jul 13, 2022
@owent owent mentioned this pull request Jul 13, 2022
Closed
3 tasks
@owent
Copy link
Member Author

owent commented Jul 14, 2022

@lalitb Could you please review this PR?
This PR also extend the utils of OTLP gRPC metrics exporter.
Hope this can be in next release together with OTLP gRPC metrics exporter.

lalitb
lalitb approved these changes Jul 14, 2022
View reviewed changes
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nicely done. There are a few improvements I can see to be done for the OTLP GRPC Metrics exporter. I will raise a PR for that.

cmake/opentelemetry-cpp-config.cmake.in Show resolved Hide resolved
exporters/otlp/include/opentelemetry/exporters/otlp/otlp_metric_utils.h Show resolved Hide resolved
@lalitb
Copy link
Member

lalitb commented Jul 15, 2022

@owent - Have some conflicts to resolve here :)

@owent owent force-pushed the otlp_metrics_exporter branch from 0acfe4d to 7ef9684 Compare July 16, 2022 05:32
@owent
Copy link
Member Author

owent commented Jul 16, 2022

@owent - Have some conflicts to resolve here :)

Resloved

@lalitb
Copy link
Member

lalitb commented Jul 19, 2022

@owent - Can you please rebase it, so can be merged.

owent added 7 commits July 19, 2022 14:37
@owent
Add OTLP http metric exporter
61b240f 
Signed-off-by: owentou <owentou@tencent.com>
@owent
Add changelog for OTLP HTTP metric exporter
19df9cc 
Signed-off-by: owentou <owentou@tencent.com>
@owent
Add unit test of SumPointData for OtlpHttpMetricExporter
bb61deb 
Signed-off-by: owentou <owentou@tencent.com>
@owent
Fix dependency of otlp recordable, add Gauge support for `OtlpMetri…
1001577 
…cUtils::PopulateRequest`

Signed-off-by: owentou <owentou@tencent.com>
@owent
Add unit test for OtlpHttpMetricExporter
fbfbd46 
Signed-off-by: owentou <owentou@tencent.com>
@owent
Fix format
3ee89d6 
Signed-off-by: owentou <owentou@tencent.com>
@owent
Fix unit test OtlpMetricSerializationTest.ObservableGauge
4fe3069 
Signed-off-by: owentou <owentou@tencent.com>
@owent owent force-pushed the otlp_metrics_exporter branch from 7ef9684 to 4fe3069 Compare July 19, 2022 06:38
@owent
Copy link
Member Author

owent commented Jul 19, 2022

@owent - Can you please rebase it, so can be merged.

Done

@lalitb lalitb merged commit 24d5100 into open-telemetry:main Jul 19, 2022
@owent owent deleted the otlp_metrics_exporter branch July 20, 2022 03:09
@marcalff marcalff mentioned this pull request Aug 2, 2022
Closed
6 tasks
yxue pushed a commit to yxue/opentelemetry-cpp that referenced this pull request Dec 5, 2022
@owent @yxue
[Metrics] Add OTLP http metric exporter (open-telemetry#1487)
8d1f241 
* Add OTLP http metric exporter

Signed-off-by: owentou <owentou@tencent.com>

* Add changelog for OTLP HTTP metric exporter

Signed-off-by: owentou <owentou@tencent.com>

* Add unit test of `SumPointData` for `OtlpHttpMetricExporter`

Signed-off-by: owentou <owentou@tencent.com>

* Fix dependency of otlp recordable, add `Gauge` support for `OtlpMetricUtils::PopulateRequest`

Signed-off-by: owentou <owentou@tencent.com>

* Add unit test for `OtlpHttpMetricExporter`

Signed-off-by: owentou <owentou@tencent.com>

* Fix format

Signed-off-by: owentou <owentou@tencent.com>

* Fix unit test `OtlpMetricSerializationTest.ObservableGauge`

Signed-off-by: owentou <owentou@tencent.com>
yxue pushed a commit to yxue/opentelemetry-cpp that referenced this pull request Dec 5, 2022
@owent @yxue
[Metrics] Add OTLP http metric exporter (open-telemetry#1487)
39d04e6 
* Add OTLP http metric exporter

Signed-off-by: owentou <owentou@tencent.com>

* Add changelog for OTLP HTTP metric exporter

Signed-off-by: owentou <owentou@tencent.com>

* Add unit test of `SumPointData` for `OtlpHttpMetricExporter`

Signed-off-by: owentou <owentou@tencent.com>

* Fix dependency of otlp recordable, add `Gauge` support for `OtlpMetricUtils::PopulateRequest`

Signed-off-by: owentou <owentou@tencent.com>

* Add unit test for `OtlpHttpMetricExporter`

Signed-off-by: owentou <owentou@tencent.com>

* Fix format

Signed-off-by: owentou <owentou@tencent.com>

* Fix unit test `OtlpMetricSerializationTest.ObservableGauge`

Signed-off-by: owentou <owentou@tencent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcalff marcalff marcalff left review comments

@lalitb lalitb lalitb approved these changes

@ThomsonTan ThomsonTan ThomsonTan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Metrics SDK - Release Candidate
Development

Successfully merging this pull request may close these issues.

OTLP HTTP exporter for Metrics
4 participants
@owent @lalitb @ThomsonTan @marcalff