Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: urlParser will incorrect parsing url like http://abc.com/xxx@xxx/a/b #1511

Merged
merged 2 commits into from
Jul 22, 2022

Conversation

wangzhen2271
Copy link
Contributor

@wangzhen2271 wangzhen2271 commented Jul 21, 2022

Fixes issue #1509

Changes

urlParser incorrect url which "@" not in first segment, like "http://abc.com/xxx@xxx".
So I modified that it will judge if "@" is in first segment, that means before the first "/", otherwise ignore handle it.

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@wangzhen2271 wangzhen2271 requested a review from a team July 21, 2022 13:03
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 21, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #1511 (819b285) into main (0948054) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1511      +/-   ##
==========================================
+ Coverage   84.71%   84.72%   +0.01%     
==========================================
  Files         155      155              
  Lines        4778     4781       +3     
==========================================
+ Hits         4047     4050       +3     
  Misses        731      731              
Impacted Files Coverage Δ
...include/opentelemetry/ext/http/common/url_parser.h 92.00% <100.00%> (+0.52%) ⬆️

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fix. You need to fix the code format (for CI test to pass) as described here - https://github.com/open-telemetry/opentelemetry-cpp/blob/main/CONTRIBUTING.md#how-to-send-pull-requests

@wangzhen2271 wangzhen2271 force-pushed the main branch 2 times, most recently from 6db3660 to 428df97 Compare July 22, 2022 01:53
Copy link
Member

@owent owent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lalitb lalitb merged commit a77ec80 into open-telemetry:main Jul 22, 2022
yxue pushed a commit to yxue/opentelemetry-cpp that referenced this pull request Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants