-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: urlParser will incorrect parsing url like http://abc.com/xxx@xxx/a/b #1511
Conversation
|
Codecov Report
@@ Coverage Diff @@
## main #1511 +/- ##
==========================================
+ Coverage 84.71% 84.72% +0.01%
==========================================
Files 155 155
Lines 4778 4781 +3
==========================================
+ Hits 4047 4050 +3
Misses 731 731
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fix. You need to fix the code format (for CI test to pass) as described here - https://github.com/open-telemetry/opentelemetry-cpp/blob/main/CONTRIBUTING.md#how-to-send-pull-requests
6db3660
to
428df97
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(open-telemetry#1511) Co-authored-by: Lalit Kumar Bhasin <labhas@microsoft.com>
Fixes issue #1509
Changes
urlParser incorrect url which "@" not in first segment, like "http://abc.com/xxx@xxx".
So I modified that it will judge if "@" is in first segment, that means before the first "/", otherwise ignore handle it.
CHANGELOG.md
updated for non-trivial changes