-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metrics SDK] Metric aggregation temporality controls #1541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalitb
changed the title
metric aggregation temporality controls
Metric aggregation temporality controls
Aug 4, 2022
Codecov Report
@@ Coverage Diff @@
## main #1541 +/- ##
==========================================
- Coverage 83.96% 83.93% -0.03%
==========================================
Files 156 156
Lines 4905 4908 +3
==========================================
+ Hits 4118 4119 +1
- Misses 787 789 +2
|
lalitb
changed the title
Metric aggregation temporality controls
[Metrics SDK] Metric aggregation temporality controls
Aug 4, 2022
ThomsonTan
reviewed
Aug 5, 2022
exporters/otlp/include/opentelemetry/exporters/otlp/otlp_grpc_metric_exporter_options.h
Outdated
Show resolved
Hide resolved
ThomsonTan
reviewed
Aug 5, 2022
ThomsonTan
approved these changes
Aug 5, 2022
@lalitb can you please resolve the merging conflict? |
Fixed. Thanks. |
yxue
pushed a commit
to yxue/opentelemetry-cpp
that referenced
this pull request
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1339
Changes
As preferred aggregation temporality concept is removed from specs, and is made as function of instrument-kind (see section here - https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/sdk.md#metricreader) , following changes are done -
GetAggregationTemporality()
method in MetricReader. The methods now take in instrument type/kind, that lets exporter find which temporality to use based on the instrument.GetAggregationTemporality()
method in MetricExporter. This method takes the instrument type/kind, and returns the correct temporality to use based on the exporter used -For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes