-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
METRICS SDK - Calling Observable Instruments callback during metrics collection #1554
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1554 +/- ##
==========================================
+ Coverage 83.38% 85.02% +1.64%
==========================================
Files 156 156
Lines 4975 4977 +2
==========================================
+ Hits 4148 4231 +83
+ Misses 827 746 -81
|
is this finished? |
Yes changes are fine, as I tested with ostream exporter, I need to add unit test. Will be finishing it today. |
I have now added basic tests to validate the async flow, it should be good to review now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the fix.
Fixes #1550, #1556
Changes
Please provide a brief description of the changes here.
Meter::Collect()
), call all the registered callbacks once.For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes