-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix header only api singletons (#1520) #1604
Conversation
This fix is for gcc and clang only.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1604 +/- ##
==========================================
+ Coverage 85.22% 85.30% +0.09%
==========================================
Files 156 156
Lines 4978 4978
==========================================
+ Hits 4242 4246 +4
+ Misses 736 732 -4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we disable component_c .. component_f and keep component_a and component_b on Windows?
Do not build unit test code in windows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, can we merged once conflict is resolved.
Thanks. |
This fix is for gcc and clang only.
Fixes #1520
Changes
Add compiler annotations to make singleton methods visible.
This is needed by the linker to ensure uniqueness of singletons.
CHANGELOG.md
updated for non-trivial changes