-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build warnings #1613
Fix build warnings #1613
Conversation
Fix build warnings reported by gcc 10, with: -Wall -Werror -Wextra-semi -Werror=unused-parameter -Werror=undef
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1613 +/- ##
==========================================
- Coverage 85.24% 85.22% -0.02%
==========================================
Files 156 156
Lines 4978 4978
==========================================
- Hits 4243 4242 -1
- Misses 735 736 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but as it's bigger cleanup, will wait for one more approval :). Thanks for taking this.
remove debug code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after the dead codes removed.
The DocFX check build failed due to this:
which looks like a transient error unrelated to the change. This PR is ready for merge now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the fix :)
related to #249 |
Fixes #1611
Changes
Fix build warnings reported by gcc 10, with:
-Wall -Werror
-Wextra-semi
-Werror=unused-parameter
-Werror=undef
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes