Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logs SDK] LogProcessor, LogExporter changes #1727

Merged
merged 3 commits into from
Nov 4, 2022
Merged

[Logs SDK] LogProcessor, LogExporter changes #1727

merged 3 commits into from
Nov 4, 2022

Conversation

owent
Copy link
Member

@owent owent commented Nov 1, 2022 •
edited
Loading

Signed-off-by: owent admin@owent.net

Fixes #1694

Changes

These are break changes.

  • Rename LogProcessor to LogRecordProcessor
  • Rename LogExporter to LogRecordExporter
  • Move *log_processor* to *log_record_processor*
  • Move *log_exporter* to *log_record_exporter*

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@owent
+ Rename LogProcessor to LogRecordProcessor
6435d87 
+ Rename `LogExporter` to `LogRecordExporter`
+ Move `*log_processor*` to `*log_record_processor*`
+ Move `*log_exporter*` to `*log_record_exporter*`

Signed-off-by: owent <admin@owent.net>
@owent owent requested a review from a team November 1, 2022 08:27
@codecov
Copy link

codecov bot commented Nov 1, 2022 •
edited
Loading

Codecov Report

Merging #1727 (bb9a06d) into main (7812651) will increase coverage by 0.06%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1727      +/-   ##
==========================================
+ Coverage   85.73%   85.79%   +0.06%     
==========================================
  Files         171      171              
  Lines        5212     5212              
==========================================
+ Hits         4468     4471       +3     
+ Misses        744      741       -3
Impacted Files Coverage Δ
ext/src/http/client/curl/http_client_curl.cc 81.44% <0.00%> (+1.14%) ⬆️

@owent
Add changelog
01cad63 
Signed-off-by: owent <admin@owent.net>
@owent
Copy link
Member Author

owent commented Nov 4, 2022

Is it possiable to review and merge this PR first, before other changes.
There are a lot of renames in this PR, and it's easy to conflict with others.
@open-telemetry/cpp-approvers

marcalff
marcalff approved these changes Nov 4, 2022
View reviewed changes
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

esigo
esigo approved these changes Nov 4, 2022
View reviewed changes
Copy link
Member

@esigo esigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for the fix :)

@esigo esigo merged commit 7634edf into open-telemetry:main Nov 4, 2022
@lalitb
Copy link
Member

lalitb commented Nov 4, 2022 •
edited
Loading

One minor comment - Should we be changing all the exporters class names to use "*LogRecordExporter", to be in consistent with the file-names, and naming of their cmake/bazel targets?

So,
ElasticsearchLogExporter to ElasticsearchLogRecordExporter
OStreamLogExporter to OStreamLogRecordExporter
OtlpGrpcLogExporter to OtlpGrpcLogRecordExporter
OtlpHttpLogExporter to OtlpHttpLogRecordExporter

And similarly for Processors:
BatchLogProcessor to BarchLogRecordProcessor
SimpleLogProcessor to SimpleLogRecordProcessor
MultiLogProcessor to MultiLogRecordProcessor

@esigo
Copy link
Member

esigo commented Nov 4, 2022

One minor comment - Should we be changing all the exporters class names to use "*LogRecordExporter", to be in consistent with the file-names, and naming of their cmake/bazel targets?

So, ElasticsearchLogExporter to ElasticsearchLogRecordExporter OStreamLogExporter to OStreamLogRecordExporter OtlpGrpcLogExporter to OtlpGrpcLogRecordExporter OtlpHttpLogExporter to OtlpHttpLogRecordExporter

And similarly for Processors: BatchLogProcessor to BarchLogRecordProcessor SimpleLogProcessor to SimpleLogRecordProcessor

yeah, I can do it tomorrow.

lalitb
lalitb reviewed Nov 4, 2022
View reviewed changes
sdk/src/logs/multi_log_record_processor_factory.cc
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

#ifdef ENABLE_LOGS_PREVIEW
Copy link
Member

@lalitb lalitb Nov 4, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to this PR, but I think we can later remove the factory class for MultiLogRecordProcessor, as this class is only used internally in SDK.

yxue pushed a commit to yxue/opentelemetry-cpp that referenced this pull request Dec 5, 2022
@owent @esigo @yxue
[Logs SDK] LogProcessor, LogExporter changes (open-telemetry#1727)
5407b9d 
* + Rename `LogProcessor` to `LogRecordProcessor`
+ Rename `LogExporter` to `LogRecordExporter`
+ Move `*log_processor*` to `*log_record_processor*`
+ Move `*log_exporter*` to `*log_record_exporter*`

Signed-off-by: owent <admin@owent.net>

* Add changelog

Signed-off-by: owent <admin@owent.net>

Signed-off-by: owent <admin@owent.net>
Co-authored-by: Ehsan Saei <71217171+esigo@users.noreply.github.com>
yxue pushed a commit to yxue/opentelemetry-cpp that referenced this pull request Dec 5, 2022
@owent @esigo @yxue
[Logs SDK] LogProcessor, LogExporter changes (open-telemetry#1727)
22debae 
* + Rename `LogProcessor` to `LogRecordProcessor`
+ Rename `LogExporter` to `LogRecordExporter`
+ Move `*log_processor*` to `*log_record_processor*`
+ Move `*log_exporter*` to `*log_record_exporter*`

Signed-off-by: owent <admin@owent.net>

* Add changelog

Signed-off-by: owent <admin@owent.net>

Signed-off-by: owent <admin@owent.net>
Co-authored-by: Ehsan Saei <71217171+esigo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lalitb lalitb lalitb left review comments

@esigo esigo esigo approved these changes

@marcalff marcalff marcalff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Logs SDK] LogProcessor, LogExporter changes
4 participants
@owent @lalitb @esigo @marcalff