[Build] Bring your own dependency: opentelemetry-proto

[marcalff]

Fixes #1719

Changes

Add option OTELCPP_PROTO_PATH in CMake.

• CHANGELOG.md updated for non-trivial changes
• Unit tests have been added
• Changes in public API reviewed

[codecov]

Codecov Report

Merging #1730 (a5e9246) into main (34b6597) will increase coverage by 0.06%.
The diff coverage is n/a.

❗ Current head a5e9246 differs from pull request most recent head 5d8cee3. Consider uploading reports for the commit 5d8cee3 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1730      +/-   ##
==========================================
+ Coverage   85.73%   85.79%   +0.06%     
==========================================
  Files         171      171              
  Lines        5212     5212              
==========================================
+ Hits         4468     4471       +3     
+ Misses        744      741       -3     

Impacted Files	Coverage Δ
ext/src/http/client/curl/http_client_curl.cc	81.44% <0.00%> (+1.14%)	⬆️

[owent]

LGTM.
Is it better to set OTELCPP_PROTO_PATH when using internal proto by ExternalProject_Add?

[lalitb]

LGTM. Thanks.

[marcalff]

LGTM. Is it better to set OTELCPP_PROTO_PATH when using internal proto by ExternalProject_Add?

Thanks @owent

I don't understand the suggestion itself.

Do you mean to set OTELCPP_PROTO_PATH as well after:

    ExternalProject_Add(
      opentelemetry-proto
      GIT_REPOSITORY https://github.com/open-telemetry/opentelemetry-proto.git
      GIT_TAG "${opentelemetry-proto}"
      UPDATE_COMMAND ""
      BUILD_COMMAND ""
      INSTALL_COMMAND ""
      CONFIGURE_COMMAND ""
      TEST_AFTER_INSTALL 0
      DOWNLOAD_NO_PROGRESS 1
      LOG_CONFIGURE 1
      LOG_BUILD 1
      LOG_INSTALL 1)
    ExternalProject_Get_Property(opentelemetry-proto INSTALL_DIR)
    set(PROTO_PATH "${INSTALL_DIR}/src/opentelemetry-proto")

If so, this would mean the makefile alter choices made by the user, making it unclear if this variable is an input to the makefile, or an output from the makefile (when using submodules and/or a github download), of both, causing confusion in my opinion.

Please clarify.

[lalitb]

LGTM. Is it better to set OTELCPP_PROTO_PATH when using internal proto by ExternalProject_Add?

Thanks @owent

I don't understand the suggestion itself.

Do you mean to set OTELCPP_PROTO_PATH as well after:

    ExternalProject_Add(
      opentelemetry-proto
      GIT_REPOSITORY https://github.com/open-telemetry/opentelemetry-proto.git
      GIT_TAG "${opentelemetry-proto}"
      UPDATE_COMMAND ""
      BUILD_COMMAND ""
      INSTALL_COMMAND ""
      CONFIGURE_COMMAND ""
      TEST_AFTER_INSTALL 0
      DOWNLOAD_NO_PROGRESS 1
      LOG_CONFIGURE 1
      LOG_BUILD 1
      LOG_INSTALL 1)
    ExternalProject_Get_Property(opentelemetry-proto INSTALL_DIR)
    set(PROTO_PATH "${INSTALL_DIR}/src/opentelemetry-proto")

If so, this would mean the makefile alter choices made by the user, making it unclear if this variable is an input to the makefile, or an output from the makefile (when using submodules and/or a github download), of both, causing confusion in my opinion.

Please clarify.

@owent Do you have any further comments, or can this be merged. thanks.