Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metrics SDK] Cleanup of old _metric api/sdk #1734

Merged
merged 4 commits into from
Nov 6, 2022
Merged

[Metrics SDK] Cleanup of old _metric api/sdk #1734

merged 4 commits into from
Nov 6, 2022

Conversation

esigo
Copy link
Member

@esigo esigo commented Nov 5, 2022 •
edited
Loading

This does cleanup as part of #1573 - delete files under api//_metrics, sdk//_metrics directory.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@codecov
Copy link

codecov bot commented Nov 5, 2022 •
edited
Loading

Codecov Report

Merging #1734 (a336d02) into main (99a9b4c) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1734   +/-   ##
=======================================
  Coverage   85.79%   85.79%           
=======================================
  Files         171      171           
  Lines        5212     5212           
=======================================
  Hits         4471     4471           
  Misses        741      741

@esigo esigo marked this pull request as ready for review November 5, 2022 13:36
@esigo esigo requested a review from a team November 5, 2022 13:36
@esigo esigo added the metrics label Nov 5, 2022
owent
owent reviewed Nov 6, 2022
View reviewed changes
Copy link
Member

@owent owent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prometheus_exporter_deprecated in cmake/opentelemetry-cpp-config.cmake.in can also be removed.

@esigo
Copy link
Member Author

esigo commented Nov 6, 2022

prometheus_exporter_deprecated in cmake/opentelemetry-cpp-config.cmake.in can also be removed.

Thanks @owent, done

marcalff
marcalff approved these changes Nov 6, 2022
View reviewed changes
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@marcalff marcalff mentioned this pull request Nov 6, 2022
Merged
3 tasks
lalitb
lalitb approved these changes Nov 6, 2022
View reviewed changes
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@esigo esigo merged commit ec8895b into open-telemetry:main Nov 6, 2022
@esigo esigo deleted the remove-_metrics branch November 6, 2022 18:31
yxue pushed a commit to yxue/opentelemetry-cpp that referenced this pull request Dec 5, 2022
@esigo @yxue
[Metrics SDK] Cleanup of old _metric api/sdk (open-telemetry#1734)
180b3b9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owent owent owent left review comments

@marcalff marcalff marcalff approved these changes

@lalitb lalitb lalitb approved these changes

Assignees
No one assigned
Labels
metrics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@esigo @lalitb @owent @marcalff