-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved otlp_grpc_utils.cc to opentelemetry_exporter_otlp_grpc_client. #1829
Conversation
Shall we make this consistent with our bazel? opentelemetry-cpp/exporters/otlp/BUILD Lines 50 to 64 in 82d8cb4
|
Yes, good point to be consistent with bazel. Will do so |
Or should we have single library otlp_grpc_client for both bazel and cmake, as in the latest changes in this PR - I don't see reason to have two different libraries for gRPC stuff. |
Yeah agree. doesn't make sense to have two libs. |
Nit - In the PR description and title: Added otlp_grpc_utils.cc in the opentelemetry_exporter_otlp_grpc. -> Moved otlp_grpc_utils.cc to opentelemetry_exporter_otlp_grpc_client. |
+1. Put all grpc specific code in otlp_grpc_client makes sense for both bazel and cmake. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the fix :)
Fixes #1826
Changes
Moved otlp_grpc_utils.cc to opentelemetry_exporter_otlp_grpc_client.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes