Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused namespace alias for nostd #1914

Merged
merged 2 commits into from
Jan 10, 2023

Conversation

ThomsonTan
Copy link
Contributor

Changes

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@ThomsonTan ThomsonTan requested a review from a team January 10, 2023 19:20
@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@65c22e9). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1914   +/-   ##
=======================================
  Coverage        ?   85.72%           
=======================================
  Files           ?      171           
  Lines           ?     5252           
  Branches        ?        0           
=======================================
  Hits            ?     4502           
  Misses          ?      750           
  Partials        ?        0           

Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the cleanup.

@lalitb lalitb enabled auto-merge (squash) January 10, 2023 21:47
@lalitb lalitb merged commit 57d1a47 into open-telemetry:main Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants