-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup CMake makefiles for CURL usage #1916
Conversation
Explicitly ask for OTLP_HTTP
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1916 +/- ##
==========================================
+ Coverage 86.16% 86.90% +0.75%
==========================================
Files 171 165 -6
Lines 5257 4594 -663
==========================================
- Hits 4529 3992 -537
+ Misses 728 602 -126 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need also add -DWITH_EXAMPLES_HTTP=ON
in at least one CI job? Or we can not ensure the http example can be compiled success.
Good point, looking into this. |
Resolved, tests build in maintainer mode. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with nit comments :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the fix :)
This is to force CI to rebuild in github, stuck with no recovery in github UI.
Fixes #1913
Changes
General CMake cleanup related to CURL:
find_package(CURL)
, usedfind_package(CURL)
from only one place in the top level makefile,if(CURL_FOUND)
tests, which are semantically incorrect. A given library should be compiled when there is a reason to build it, not because CURL happens to be available. This also make the build more robust in a super build, when unrelated packages can useCURL
and setCURL_FOUND
for unrelated reasons,WITH_OTLP_HTTP
option to be predictable,See the CHANGELOG Important changes section for more details.
CHANGELOG.md
updated for non-trivial changes