-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINTAINER DOC] Define and document a deprecation process #1923
[MAINTAINER DOC] Define and document a deprecation process #1923
Conversation
Example of deprecation, for jaeger.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1923 +/- ##
==========================================
- Coverage 87.12% 87.10% -0.02%
==========================================
Files 165 165
Lines 4596 4596
==========================================
- Hits 4004 4003 -1
- Misses 592 593 +1
|
Thanks, a very well thought-out and documented process. This will indeed smoothen the deprecation process. Have few nit comments :) |
Co-authored-by: Lalit Kumar Bhasin <lalit_fin@yahoo.com>
improved process doc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the PR :)
Co-authored-by: Ehsan Saei <71217171+esigo@users.noreply.github.com>
Done with the last edits, now ready for formal review and merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, fixed.
Actually, this doc needs no changes. The This documentation is about setting up |
exporters/jaeger/include/opentelemetry/exporters/jaeger/jaeger_exporter_options.h
Show resolved
Hide resolved
Yes, didn't realize it is using OTLP exporter to send the traces. |
Co-authored-by: Tom Tan <lilotom@gmail.com>
Fixes #1893
Fixes #1892
Changes
This change contains:
MAINTAINER_MODE
code without deprecated items.Also, it contains the actual deprecation for the Jaeger Exporter:
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes