upgrade prometheus-cpp to v1.1.0 #1954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1954 +/- ##
=======================================
Coverage 87.12% 87.12%
=======================================
Files 165 165
Lines 4596 4596
=======================================
Hits 4004 4004
Misses 592 592 |
lalitb
commented
Feb 4, 2023
| ASSERT_TRUE(false); | ||
| break; | ||
| case prometheus::MetricType::Untyped: | ||
| break; | ||
| default: |
There was a problem hiding this comment.
v.1.1.0 adds a new metric type as MetricType::Info. Adding default to handle that (and keep maintainer mode CI happy).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # (issue)
Changes
The earlier version v1.0.0 was released on Nov 2021.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes