[ETW Exporter]Support serialize span/log attributes into JSON #1991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1991 +/- ##
=======================================
Coverage 87.29% 87.29%
=======================================
Files 166 166
Lines 4662 4662
=======================================
Hits 4069 4069
Misses 593 593 |
lalitb
reviewed
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1990
Changes
As ETW exporter is header only, this PR provide a C++ macro
ENABLE_ENV_PROPERTIES, when defined, does serialization on all span/log attributes to a single attribute with JSON representation of all the attributes.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes