Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make merging resource schema url in line with the spec #2039

Closed
wants to merge 2 commits into from

Conversation

ThomsonTan
Copy link
Contributor

@ThomsonTan ThomsonTan commented Mar 9, 2023

Fixes #2035

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@ThomsonTan ThomsonTan requested a review from a team March 9, 2023 22:58
@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #2039 (4e8efae) into main (5046443) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2039      +/-   ##
==========================================
+ Coverage   87.30%   87.33%   +0.03%     
==========================================
  Files         166      166              
  Lines        4723     4726       +3     
==========================================
+ Hits         4123     4127       +4     
+ Misses        600      599       -1     
Impacted Files Coverage Δ
sdk/src/resource/resource.cc 96.67% <100.00%> (+0.38%) ⬆️

... and 1 file with indirect coverage changes

@ThomsonTan
Copy link
Contributor Author

This is duped with #2036, close it for now.

@ThomsonTan ThomsonTan closed this Mar 9, 2023
@ThomsonTan ThomsonTan deleted the FixResourceMerge branch March 13, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Resource SDK] Merge implementation favors "updating" schema_url over "old" schema_url when empty
1 participant