Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUILD] Include directory path added for Zipkin exporter example #2069

Merged
merged 2 commits into from
Mar 23, 2023
Merged

[BUILD] Include directory path added for Zipkin exporter example #2069

merged 2 commits into from
Mar 23, 2023

Conversation

cngzhnp
Copy link
Contributor

@cngzhnp cngzhnp commented Mar 23, 2023

Fixes #2068

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 23, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: cngzhnp / name: Cengizhan Pasaoglu (f646244)

@cngzhnp cngzhnp marked this pull request as ready for review March 23, 2023 13:13
@cngzhnp cngzhnp requested a review from a team March 23, 2023 13:13
@codecov
Copy link

codecov bot commented Mar 23, 2023 •
edited
Loading

Codecov Report

Merging #2069 (a357ff8) into main (2b2fe44) will decrease coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2069      +/-   ##
==========================================
- Coverage   87.17%   87.15%   -0.02%     
==========================================
  Files         166      166              
  Lines        4746     4746              
==========================================
- Hits         4137     4136       -1     
- Misses        609      610       +1

see 1 file with indirect coverage changes

marcalff
marcalff requested changes Mar 23, 2023
View reviewed changes
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On hold for now, need to reproduce the break first.

owent
owent approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@owent owent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

@marcalff marcalff self-requested a review March 23, 2023 17:32
marcalff
marcalff approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, so the code is similar to other exporters (jaeger, otlp), and was missing for zipkin.

LGTM, thanks for the fix.

@lalitb lalitb enabled auto-merge (squash) March 23, 2023 18:14
@lalitb lalitb merged commit fb3bcb5 into open-telemetry:main Mar 23, 2023
@marcalff marcalff changed the title Include directory path added for Zipkin exporter example [BUILD] Include directory path added for Zipkin exporter example Apr 12, 2023
@chuanchan1116 chuanchan1116 mentioned this pull request Apr 19, 2023
Closed
ays7 added a commit to ays7/opentelemetry-cpp that referenced this pull request May 18, 2023
@ays7
Merge v1.9.0
d44532c 
* commit '7887d32da60f54984a597abccbb0c883f3a51649': (82 commits)
  [RELEASE] Release version 1.9.0 (open-telemetry#2091)
  Use sdk_start_ts for MetricData start_ts for instruments having cumulative aggregation temporality. (open-telemetry#2086)
  [SEMANTIC CONVENTIONS] Upgrade to version 1.20.0 (open-telemetry#2088)
  [EXPORTER] Add OTLP HTTP SSL support (open-telemetry#1793)
  Make Windows build environment parallel (open-telemetry#2080)
  make some hints (open-telemetry#2078)
  Make some targets parallel in CI pipeline (open-telemetry#2076)
  [Metrics SDK] Implement Forceflush for Periodic Metric Reader (open-telemetry#2064)
  Upgraded semantic conventions to 1.19.0 (open-telemetry#2017)
  Bump actions/stale from 7 to 8 (open-telemetry#2070)
  Include directory path added for Zipkin exporter example (open-telemetry#2069)
  Ignore more warning of generated protobuf files than not included in `-Wall` and `-Wextra` (open-telemetry#2067)
  Add `ForceFlush` for all `LogRecordExporter`s and `SpanExporter`s. (open-telemetry#2000)
  Remove unused 'alerting' section from prometheus.yml in examples (open-telemetry#2055)
  Clean warnings in ETW exporters (open-telemetry#2063)
  Fix default value of `OPENTELEMETRY_INSTALL_default`. (open-telemetry#2062)
  [EXPORTER] GRPC endpoint scheme should take precedence over OTEL_EXPORTER_OTLP_TRACES_INSECURE (open-telemetry#2060)
  Fix view names in Prometheus example (open-telemetry#2034)
  Fix some docs typo (open-telemetry#2057)
  Checking indices before dereference (open-telemetry#2040)
  ...

# Conflicts:
#	exporters/ostream/CMakeLists.txt
#	sdk/src/metrics/state/metric_collector.cc
#	sdk/src/metrics/state/temporal_metric_storage.cc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcalff marcalff marcalff approved these changes

@owent owent owent approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Zipkin example is not compiled successfully due to missing header file error
4 participants
@cngzhnp @owent @marcalff @lalitb