-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Upgrade Google Benchmark version from 1.6.0 to 1.7.1 #2116
[CI] Upgrade Google Benchmark version from 1.6.0 to 1.7.1 #2116
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Please update the third_party_release too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix
cda9bc9
to
3ed3243
Compare
ci/ports/benchmark is special backport for old compilers, I think we can leave it. However for windows, we should sometime update the vcpkg submodule (as done in #1633), this can be handled as separate PR. |
Fixes # (issue)
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes