Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Thrift version from 0.14.1 to 0.18.1 #2119

Closed

Conversation

cngzhnp
Copy link
Contributor

@cngzhnp cngzhnp commented Apr 24, 2023

Fixes # (issue)

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Merging #2119 (a536cc6) into main (a39e8b5) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2119   +/-   ##
=======================================
  Coverage   87.19%   87.19%           
=======================================
  Files         166      166           
  Lines        4784     4784           
=======================================
  Hits         4171     4171           
  Misses        613      613           

@esigo
Copy link
Member

esigo commented May 17, 2023

@cngzhnp thanks for the PR, the dependency on Thrift will be removed in #2031.

@marcalff
Copy link
Member

@cngzhnp

Thanks for the PR.

As noted earlier, the Jaeger exporter is going away, so that thrift will also be removed.

There is no need to upgrade thrift then, so this PR can be closed.

@cngzhnp cngzhnp closed this May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants