Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD] Warning cleanup, single character wrapped by std::string #2137

Merged
merged 2 commits into from
May 11, 2023
Merged

[BUILD] Warning cleanup, single character wrapped by std::string #2137

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
303973b
Single character wrapped by std::string to get rid of warning
cngzhnp May 11, 2023
5375fae
Merge branch 'main' into fix/issue_single_character_warning
ThomsonTan May 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ext/include/opentelemetry/ext/http/common/url_parser.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ class UrlParser
pos = url_.find_first_of("/?", cpos);
if (pos == std::string::npos)
{
path_ = "/"; // use default path
path_ = std::string("/"); // use default path
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put the GCC bug link here for reference?

if (is_port)
{
port_ = static_cast<uint16_t>(
Expand Down Expand Up @@ -122,7 +122,7 @@ class UrlParser
}
return;
}
path_ = "/";
path_ = std::string("/");
if (url_[cpos] == '?')
{
query_ = std::string(url_.begin() + cpos, url_.begin() + url_.length());
Expand Down