Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Add a C++11 build #2152

Merged
merged 4 commits into from
May 26, 2023
Merged

[CI] Add a C++11 build #2152

merged 4 commits into from
May 26, 2023

Conversation

marcalff
Copy link
Member

@marcalff marcalff commented May 23, 2023 •
edited
Loading

Fixes #2151

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff marcalff requested a review from a team May 23, 2023 15:55
@codecov
Copy link

codecov bot commented May 23, 2023 •
edited
Loading

Codecov Report

Merging #2152 (6aa809f) into main (3707bc0) will decrease coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2152      +/-   ##
==========================================
- Coverage   87.17%   87.13%   -0.04%     
==========================================
  Files         166      166              
  Lines        4777     4777              
==========================================
- Hits         4164     4162       -2     
- Misses        613      615       +2

see 1 file with indirect coverage changes

owent
owent approved these changes May 23, 2023
View reviewed changes
Copy link
Member

@owent owent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thanks

esigo
esigo reviewed May 23, 2023
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@marcalff
Copy link
Member Author

@esigo

Thanks for the previous comments.

The use of thrift is now removed, please take another look and approve.

@marcalff marcalff mentioned this pull request May 26, 2023
Merged
3 tasks
esigo
esigo approved these changes May 26, 2023
View reviewed changes
Copy link
Member

@esigo esigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
thanks :)

@esigo esigo added the ok-to-merge The PR is ok to merge (has two approves or raised by a maintainer/approver and has one approve) label May 26, 2023
@marcalff marcalff merged commit f553462 into open-telemetry:main May 26, 2023
@chenrui333 chenrui333 mentioned this pull request Jul 14, 2023
Merged
@marcalff marcalff deleted the fix_ci_cpp11_1251 branch September 5, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esigo esigo esigo approved these changes

@owent owent owent approved these changes

Assignees
No one assigned
Labels
ok-to-merge The PR is ok to merge (has two approves or raised by a maintainer/approver and has one approve)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CI] Add a C++11 build
3 participants
@marcalff @owent @esigo