-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support protobuf 3.22 or upper #2163
Merged
lalitb
merged 54 commits into
open-telemetry:main
from
owent:support_protobuf_3.22_or_upper
Aug 11, 2023
Merged
Changes from 1 commit
Commits
Show all changes
54 commits
Select commit
Hold shift + click to select a range
fbb68dd
Support protobuf 3.22 or upper
owent 5c013c0
Test modern gRPC
owent 7b5f955
Fix dependency
owent f95fd57
Using installed protobuf to build gRPC when using modern protobuf and…
owent f016a75
Make install_abseil.sh has the same options like it in setup_grpc.sh
owent c94e488
Fix abseil-cpp dependency of proto when using protobuf 3.22 or upper.
owent 0dc7575
Fix protobuf installer with package absl.
owent 8db4a61
Fix CI job for custom protobuf and abseil version
owent 0f0085a
Allow to set `CXX_STANDARD` by environment variable in CI job.
owent 1dcceaa
Update modern gRPC version
owent 6fa4e95
Fix gcc version detection
owent 93d347c
Fix abseil-cpp checking.
owent 234ab40
Fix stringpiece including.
owent 8956193
Fix link order of grpc example
owent 5f3e6db
Patch dependencies.
owent 8a36378
Allow to ignore more libraries's CONFIGs.
owent 2ecaf75
Patch several third party libraries to allow they are built in a diff…
owent ace2e84
Support GTest cmake package
owent 2e1af98
Optimize protoc execute.
owent c562424
Rename `proto-options-patch.cmake` to `tools.cmake`
owent 77f4ec1
Support set PROTOBUF_PROTOC_EXECUTABLE from protobuf::protoc
owent 1fa8631
Fix GTest package on Windows
owent d3db7c8
Merge remote-tracking branch 'opentelemetry/main' into support_protob…
owent 68aa11c
Restore `WITH_OTLP_GRPC` in `cmake.maintainer.sync.test`
owent f63e145
Fix sepss problem.
owent 0ba0fb2
Merge branch 'main' into support_protobuf_3.22_or_upper
ThomsonTan f2e3009
Fix undefined uint64_t in metrics headers.
owent 53ef61b
Merge remote-tracking branch 'opentelemetry/main' into support_protob…
owent 85bea45
Remove the legacy `protobuf_MODULE_COMPATIBLE` requirement.
owent b903710
Fix format
owent f783127
Merge branch 'main' into support_protobuf_3.22_or_upper
marcalff afed730
Try to use c++14 for modern protobuf and gRPC
owent 22e767c
Merge remote-tracking branch 'github/main' into support_protobuf_3.22…
owent ecdc611
Merge remote-tracking branch 'github/main' into support_protobuf_3.22…
owent 43f5996
Use environment to control c++ standardn in CI jobs.
owent 95fb02d
Merge branch 'main' into support_protobuf_3.22_or_upper
owent a947146
Merge remote-tracking branch 'github/main' into support_protobuf_3.22…
owent b24f299
Restore the changelogs by mistake.
owent 052dfea
Merge branch 'main' into support_protobuf_3.22_or_upper
owent c73f9b8
Ignore more warnings os MSVC for protobuf generated sources.
owent 7a2c75b
Remove different package CONFIG supporting.
owent 46caba6
Merge remote-tracking branch 'github/main' into support_protobuf_3.22…
owent 5e08424
Merge branch 'main' into support_protobuf_3.22_or_upper
lalitb ef1f0be
Add CI job without abseil
owent bb90f44
Merge remote-tracking branch 'origin/support_protobuf_3.22_or_upper' …
owent edeed26
Remove dependency of absl for OTLP HTTP client.
owent 9bfce35
Fix type
owent 0d3b76f
Move base64 encoder and decoder into sdk
owent 67dc6ff
Early exit if base64 source is empty
owent b8f2e5c
Fix including
owent c996738
Fix style
owent ec5f39e
Remove unsupport base64 format of absl
owent fd9dc99
Fix including
owent fdff03d
Restore protobuf and abseil checking
owent File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should these methods be moved to https://github.com/open-telemetry/opentelemetry-cpp/blob/main/api/include/opentelemetry/common/string_util.h ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a lot of codes here, do you think it's better to move it into sdk?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah good point, not required. We can move it later if need to share with other components. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
base64 algorithm is moved into sdk now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really sorry if my comment above was not clear. I did realize that this will bloat the sdk, and we should move it only when we need to share it with other components.