Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EXPORTER] Fixed HTTP CURL for 32bits platforms #2178

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

marcalff
Copy link
Member

@marcalff marcalff commented Jun 5, 2023

Fixes #2175

Changes

Fixed the HTTP CURL implementation to use the proper data types, when using options with type curl_off_t.

This fixes 32 bits builds, like WIN32.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

Copy link
Member

@owent owent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thanks.

@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #2178 (74305b8) into main (834c0c4) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2178   +/-   ##
=======================================
  Coverage   87.52%   87.52%           
=======================================
  Files         169      169           
  Lines        4887     4887           
=======================================
  Hits         4277     4277           
  Misses        610      610           

Copy link
Member

@esigo esigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks :)

@esigo esigo added the ok-to-merge The PR is ok to merge (has two approves or raised by a maintainer/approver and has one approve) label Jun 5, 2023
@marcalff marcalff merged commit 500cf98 into open-telemetry:main Jun 6, 2023
@marcalff marcalff deleted the fix_curl_win32_2175 branch September 5, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-merge The PR is ok to merge (has two approves or raised by a maintainer/approver and has one approve)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

set option <30120> failed: <A libcurl function was given a bad argument>
5 participants