[BUILD] Avoid dependency on protobuf from the OTLP HTTP metrics exporter header #2179
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2169
Changes
Simplify the header dependencies for file:
exporters/otlp/include/opentelemetry/exporters/otlp/otlp_http_metric_exporter.h
The declaration of class
OtlpHttpMetricExporter
does not need to see code inotlp_metric_utils.h
, only the implementation does.Depending on
otlp_metric_utils.h
from a header file is problematic, because it brings a transitive dependency on protobuf generated code, which is not installed.This fix allows an application to instantiate a
OtlpHttpMetricExporter
object, to configure the SDK to export metrics.For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes