[SDK] Provide builders to avoid exposing Metrics SDK internals #2189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2189 +/- ##
==========================================
+ Coverage 87.53% 87.53% +0.01%
==========================================
Files 169 169
Lines 4888 4889 +1
==========================================
+ Hits 4278 4279 +1
Misses 610 610
|
marcalff
changed the title
|
Now ready for review. |
lalitb
reviewed
Jun 26, 2023
lalitb
reviewed
Jun 26, 2023
| p->AddView(std::move(histogram_instrument_selector), std::move(histogram_meter_selector), | ||
| std::move(histogram_view)); | ||
|
|
||
| std::shared_ptr<opentelemetry::metrics::MeterProvider> provider(std::move(u_provider)); |
There was a problem hiding this comment.
These multiple casts from api:::MeterProvider -> sdk::MeterProvider -> api::MeterProvider are bit confusing, but seems we don't have better choice for now.
lalitb
reviewed
Jun 26, 2023
lalitb
reviewed
Jun 26, 2023
lalitb
approved these changes
Jun 26, 2023
marcalff
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1485
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes